Review main Abandoned

68525[WIP][FEATURE] Add API to fetch current page id in the Backend mode

Dmitry Dulepov CR 0 V 0 Hard +193 −66 updated 03/22/21, 08:44

Commit message

New API to fetch the current page id in the Backend mode from
request variables. This value comes in various way for different
requests and it is difficult to extract it for all possible
cases. This mew API method means to be a central place for
getting the id while in the Backend mode.

Additionally ConditionMatcher is switched to use this method
because this method covers more cases than the original code.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 3

Review log 1123

  1. Dmitry Dulepov uploaded patch set 1 03/21/21, 12:34

  2. TYPO3com voted on patch set 1 V -1 03/21/21, 12:40 Completed build in 05m 50s on Sun, 21 Mar, 12:40 PM Test Summary: 8912 of 33163 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10256

  3. core-ci voted on patch set 1 V -1 03/21/21, 12:50 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1721

  4. Christian Kuhn commented on patch set 1 CR -1 03/21/21, 13:15

    Thanks for your patch, Dmitry. Reading the code, some details pop up: * I'd prefer it does not rely on GeneralUtility::_GP() - This for instance won't work in cli context and relying on _GP() and friends is a detail that should vanish mid-term anyways. We shouldn't introduce new usages. Instead, the request object should be hand over. * The logic relies on magic: It tests for params that are there is some contexts, sometimes - for instance when dataHandler or clipboard arguments are hand over. Those arguments are specific in the context of single controllers and do not belong to a general API that uses this knowledge to assume things. It looks as if such code belongs to hooks or controller logic that actually knows the given context. I'll thus vote this patch -1 for now, I don't think we should introduce this API as proposed.
  5. Dmitry Dulepov uploaded patch set 2 03/21/21, 13:18

  6. TYPO3com voted on patch set 2 V -1 03/21/21, 13:19 Completed build in 22s on Sun, 21 Mar, 01:19 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10257

  7. core-ci voted on patch set 2 V -1 03/21/21, 13:20 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1722

  8. Dmitry Dulepov uploaded patch set 3 03/21/21, 13:22

  9. TYPO3com voted on patch set 3 V -1 03/21/21, 13:27 Completed build in 04m 57s on Sun, 21 Mar, 01:27 PM Test Summary: 8828 of 33163 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10258

  10. core-ci voted on patch set 3 V -1 03/21/21, 13:37 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1723

  11. Dmitry Dulepov uploaded patch set 4 03/21/21, 13:40

  12. Christian Kuhn voted on patch set 4 CR -1 03/21/21, 13:46

  13. TYPO3com voted on patch set 4 V -1 03/21/21, 13:47 Completed build in 06m 45s on Sun, 21 Mar, 01:47 PM Test Summary: 32927 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10259

  14. core-ci voted on patch set 4 V -1 03/21/21, 13:50 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1724

  15. Dmitry Dulepov uploaded patch set 5 03/21/21, 13:55

  16. TYPO3com voted on patch set 5 V -1 03/21/21, 14:02 Completed build in 07m 14s on Sun, 21 Mar, 02:02 PM Test Summary: 32927 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10260

  17. core-ci voted on patch set 5 V -1 03/21/21, 14:05 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1725

  18. Dmitry Dulepov uploaded patch set 6 03/21/21, 14:13

  19. TYPO3com voted on patch set 6 V -1 03/21/21, 14:22 Completed build in 09m 31s on Sun, 21 Mar, 02:22 PM Test Summary: 32927 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10261

  20. core-ci voted on patch set 6 V -1 03/21/21, 14:24 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1726

  21. Dmitry Dulepov abandoned the change 03/21/21, 14:25

    Not interested any more.
  22. Benni Mack commented on patch set 6 03/22/21, 08:40

    @Dmitry: even if you've abandoned the patch, I stumbled over the same logic over and over again as well (e.g. FormEngine). How about we add a new "PageAspect" to the Context API which is populated via a middleware? This could also benefit in the frontend to reduce the dependency of TSFE->page and TSFE->id. What do you think? I am willing to push you change further...
  23. Dmitry Dulepov commented on patch set 6 03/22/21, 08:44

    Reply

    @Benni, my patch was for the Backend. For Frontend it is very easy to determine page id in php and TS but for Backend there is no way provided by TYPO3 at all and it is very hard to do. I tried to add a new API exactly for the Backend. Regarding middleware in Frontend, yes, I think it is a good idea and guess it could be done but as a separate patch and ticket I think.