Review main Merged

68526[BUGFIX] Proper inline synchronize/localize with FAL

Christian Kuhn CR +2 V +2 Easy +9 −0 updated 03/22/21, 08:42

Commit message

Activating inline localization appearence in TCA for inline
FAL relations works only partially: The inline child in
question is localized, but the 'shadowed' row does not vanish.

This is due to server side behavior, which does not properly
resolve an array for 'deep' relations like
aTable->sys_file_reference->sys_file_metadata.

The scenario has been added as tx_styleguide_inline_fal
inline_5 to styleguide master & 10.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 1

Review log 814

  1. Christian Kuhn uploaded patch set 1 03/21/21, 14:58

  2. TYPO3com voted on patch set 1 V +1 03/21/21, 15:05 Completed build in 07m 28s on Sun, 21 Mar, 03:05 PM Test Summary: 32907 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10262

  3. core-ci voted on patch set 1 V +1 03/21/21, 15:09 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1727

  4. Andreas Kienast voted on patch set 1 V +1 03/21/21, 15:17

  5. Christian Kuhn uploaded patch set 2 03/21/21, 17:09

  6. TYPO3com voted on patch set 2 V +1 03/21/21, 17:17 Completed build in 07m 10s on Sun, 21 Mar, 05:17 PM Test Summary: 32907 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10265

  7. core-ci voted on patch set 2 V +1 03/21/21, 17:22 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1730

  8. Andreas Kienast voted on patch set 2 V +1 CR +1 03/22/21, 06:34

  9. Georg Ringer commented on patch set 3 03/22/21, 08:08

    Published edit on patch set 2.
  10. TYPO3com voted on patch set 3 V +1 03/22/21, 08:16 Completed build in 07m 03s on Mon, 22 Mar, 08:16 AM Test Summary: 32907 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10275

  11. core-ci voted on patch set 3 V +1 03/22/21, 08:19 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1745

  12. Oli Bartsch voted on patch set 3 V +1 CR +1 03/22/21, 08:26

  13. Andreas Kienast voted on patch set 3 V +2 CR +2 03/22/21, 08:42

  14. Andreas Kienast merged patch set 4 03/22/21, 08:42