Review main Merged

68527[BUGFIX] Re-init FormEngine always after memorizing record

Andreas Kienast CR +2 V +2 Easy +5 −5 updated 03/22/21, 10:52

Commit message

TCA fields using the 'placeholder' functionality are not
initialized in inline 'localize/synchronize' scenarios.

tx_styleguide_inline_1n -> inline_1 -> input_3 has been
added to show this.

Solution is to call the required FormEngine "re-init" in
JavaScript at a different point - not only when new inline
children are added, but also when synchronizing with
default language.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 2

Review log 610

  1. Andreas Kienast uploaded patch set 1 03/21/21, 15:01

  2. TYPO3com voted on patch set 1 V +1 03/21/21, 15:08 Completed build in 07m 12s on Sun, 21 Mar, 03:08 PM Test Summary: 32907 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10263

  3. core-ci voted on patch set 1 V +1 03/21/21, 15:14 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1728

  4. Christian Kuhn uploaded patch set 2 03/21/21, 17:40

  5. TYPO3com voted on patch set 2 V +1 03/21/21, 17:47 Completed build in 07m 10s on Sun, 21 Mar, 05:47 PM Test Summary: 32907 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10266

  6. core-ci voted on patch set 2 V +1 03/21/21, 17:50 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1732

  7. Christian Kuhn voted on patch set 2 V +1 CR +1 03/22/21, 10:01

  8. Oli Bartsch voted on patch set 2 V +1 CR +1 03/22/21, 10:44

  9. Christian Kuhn voted on patch set 2 V +2 CR +2 03/22/21, 10:52

  10. Christian Kuhn merged patch set 3 03/22/21, 10:52