Review main Abandoned

68531[TASK] Get list and dropdown of tt_content in line with records

Sebastian Fischer CR 0 V 0 Easy +1 −2 updated 07/22/21, 15:20

Commit message

Previewing tt_content records on their own should not be possible.
They are intended in context of the pages they are added to and as
such, they can be previewed via the preview of the pages it self.
That's why the preview button in recordlist and dropdown are not
available like with other records.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 2

Review log 913

  1. Sebastian Fischer uploaded patch set 1 03/21/21, 18:29

  2. TYPO3com voted on patch set 1 V +1 03/21/21, 18:37 Completed build in 07m 55s on Sun, 21 Mar, 06:37 PM Test Summary: 32907 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10267

  3. core-ci voted on patch set 1 V +1 03/21/21, 18:38 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1734

  4. Christian Kuhn commented on patch set 1 03/26/21, 10:53

    hmm. Does this interfere with TCEMAIN.preview.tt_content.previewPageId, maybe? This is used for instance to store news records on some sysfolder and have the 'view' button in formengine link to some different page for frontend rendering. Maybe we should review if that tsconfig should be taken into account for tt_content click menu and list module?
  5. Sebastian Fischer commented on patch set 1 03/26/21, 14:11

    Reply

    So if i get it right, your idea is to check wether tt_content.previewPageId is set and only remove the preview button if its empty, right?
  6. Christian Kuhn commented on patch set 1 03/26/21, 14:16

    Reply Unresolved

    not 100% sure, but maybe, yes. at least we should see if this interferes with your change.
  7. Christian Kuhn commented on patch set 1 CR -1 03/26/21, 16:22

    we'll solve that differently, Sebastian will push.
  8. Sebastian Fischer uploaded patch set 2 04/03/21, 06:40

  9. TYPO3com voted on patch set 2 V +1 04/03/21, 06:47 Completed build in 06m 57s on Sat, 3 Apr, 06:47 AM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10474

  10. core-ci voted on patch set 2 V +1 04/03/21, 06:51 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2011

  11. Oli Bartsch commented on patch set 2 V -1 04/06/21, 08:26

    This removes the show button for all tt_content records in recordlist. The bug report however only describes the problem of tt_content records on "now previewable" doktypes like sys_folder. For tt_content records on "previewable" pages the button makes much sense since it also contains the anchor which is really helpful for pages with a lot of content elements. So I would like to have the button not hidden for all tt_content records but only for those on "not previewable" doktypes.
  12. Christian Kuhn commented on patch set 2 07/19/21, 18:38

    Sebastian. Even though we talked about this patch and you pushed my suggested solution, I must admit that oli's patch from https://review.typo3.org/c/Packages/TYPO3.CMS/+/69959 is better. Is that fine with you? If so, we could abandon this approach and bring in Oli's solution.
  13. Christian Kuhn abandoned the change 07/22/21, 15:20