Review main Merged

68553[BUGFIX] Fix Bootstrap 5 tooltips

Torben Hansen CR +2 V +2 Easy +14 −15 updated 03/24/21, 03:13

Commit message

With Bootstrap 5 the registration of tooltips with the "data-title"
attribute does not work any more. Instead, the "title" attribute must
be used.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Benni Mack +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 11

Review log 1220

  1. Torben Hansen uploaded patch set 1 03/21/21, 19:06

  2. TYPO3com voted on patch set 1 V +1 03/21/21, 19:13 Completed build in 06m 59s on Sun, 21 Mar, 07:13 PM Test Summary: 32907 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10270

  3. core-ci voted on patch set 1 V -1 03/21/21, 19:19 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1737

  4. Torben Hansen uploaded patch set 2 03/22/21, 10:27

  5. TYPO3com voted on patch set 2 V +1 03/22/21, 10:33 Completed build in 06m 38s on Mon, 22 Mar, 10:33 AM Test Summary: 32907 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10282

  6. core-ci voted on patch set 2 V +1 03/22/21, 10:40 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1754

  7. Torben Hansen commented on patch set 2 03/22/21, 10:47

    Note: Please see my last comments in #93790. I think we should consider to switch to "title" attribute wherever possible.
  8. Benni Mack commented on patch set 2 03/22/21, 18:12

    Hey Torben, thanks for the patch. I wondered the same a couple of weeks ago, and found out that we only need "title" instead of "data-bs-title" - https://getbootstrap.com/docs/5.0/components/tooltips/#markup - right?
  9. Torben Hansen commented on patch set 2 03/22/21, 18:59

    Reply

    Yes, I agree on this. I will update the patch so only the title attribute will be used.
  10. Torben Hansen uploaded patch set 3 03/23/21, 13:35

  11. TYPO3com voted on patch set 3 V +1 03/23/21, 13:42 Completed build in 07m 36s on Tue, 23 Mar, 01:42 PM Test Summary: 32910 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10311

  12. core-ci voted on patch set 3 V +1 03/23/21, 13:47 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1787

  13. Benni Mack commented on patch set 3 03/23/21, 14:25

    Great. Thanks for the update, added a few remarks - apart from that, let's get it in!

    InlineRecordContainer.php:619

    I think we can remove "span" here.

    PagePositionMap.php:576

    I think we should use '<span ' . BackendUtility::getRecordToolTip($row, 'tt_content') . '>' . ...'</span>'
  14. Torben Hansen uploaded patch set 4 03/23/21, 14:50

  15. Torben Hansen commented on patch set 4 03/23/21, 14:51

    InlineRecordContainer.php:619 Reply

    Done

    PagePositionMap.php:576 Reply

    Done
  16. TYPO3com voted on patch set 4 V +1 03/23/21, 14:57 Completed build in 07m 07s on Tue, 23 Mar, 02:57 PM Test Summary: 32910 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10314

  17. core-ci voted on patch set 4 V +1 03/23/21, 15:01 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1789

  18. Benni Mack voted on patch set 4 V +1 CR +1 03/23/21, 16:11

  19. Georg Ringer voted on patch set 4 V +2 CR +2 03/24/21, 03:13

  20. Georg Ringer merged patch set 5 03/24/21, 03:13