68553[BUGFIX] Fix Bootstrap 5 tooltips
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Benni Mack +1
-
Verified V +2 Done
- Georg Ringer +2
- Benni Mack +1
- TYPO3com +1 CI
- core-ci +1 CI
Issues 1
Files 11
- typo3/sysext/backend/Classes/Form/Container/InlineRecordContainer.php2+2 −2
- typo3/sysext/backend/Classes/Form/Element/InputLinkElement.php+1 −1
- typo3/sysext/backend/Classes/Form/Element/InputSlugElement.php+1 −1
- typo3/sysext/backend/Classes/Form/Element/SelectCheckBoxElement.php+1 −1
- typo3/sysext/backend/Classes/Tree/View/PagePositionMap.php2+1 −2
- typo3/sysext/backend/Classes/Utility/BackendUtility.php+1 −1
- typo3/sysext/backend/Classes/View/BackendLayout/Grid/GridColumnItem.php+1 −1
- typo3/sysext/backend/Classes/View/PageLayoutView.php+1 −1
- typo3/sysext/backend/Resources/Private/Templates/Page/SortSubPages.html+1 −1
- typo3/sysext/recordlist/Classes/RecordList/DatabaseRecordList.php+1 −1
- typo3/sysext/scheduler/Resources/Private/Partials/Backend/SchedulerModule/TaskList.html+3 −3
Review log 1220
-
Torben Hansen uploaded patch set 1 03/21/21, 19:06
-
TYPO3com voted on patch set 1 V +1 03/21/21, 19:13 Completed build in 06m 59s on Sun, 21 Mar, 07:13 PM Test Summary: 32907 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10270
-
core-ci voted on patch set 1 V -1 03/21/21, 19:19 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1737
-
Torben Hansen uploaded patch set 2 03/22/21, 10:27
-
TYPO3com voted on patch set 2 V +1 03/22/21, 10:33 Completed build in 06m 38s on Mon, 22 Mar, 10:33 AM Test Summary: 32907 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10282
-
core-ci voted on patch set 2 V +1 03/22/21, 10:40 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1754
-
Torben Hansen commented on patch set 2 03/22/21, 10:47
Note: Please see my last comments in #93790. I think we should consider to switch to "title" attribute wherever possible. -
Benni Mack commented on patch set 2 03/22/21, 18:12
Hey Torben, thanks for the patch. I wondered the same a couple of weeks ago, and found out that we only need "title" instead of "data-bs-title" - https://getbootstrap.com/docs/5.0/components/tooltips/#markup - right? -
Torben Hansen commented on patch set 2 03/22/21, 18:59
Reply
Yes, I agree on this. I will update the patch so only the title attribute will be used. -
Torben Hansen uploaded patch set 3 03/23/21, 13:35
-
TYPO3com voted on patch set 3 V +1 03/23/21, 13:42 Completed build in 07m 36s on Tue, 23 Mar, 01:42 PM Test Summary: 32910 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10311
-
core-ci voted on patch set 3 V +1 03/23/21, 13:47 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1787
-
Benni Mack commented on patch set 3 03/23/21, 14:25
Great. Thanks for the update, added a few remarks - apart from that, let's get it in!InlineRecordContainer.php:619I think we can remove "span" here.PagePositionMap.php:576I think we should use '<span ' . BackendUtility::getRecordToolTip($row, 'tt_content') . '>' . ...'</span>' -
Torben Hansen uploaded patch set 4 03/23/21, 14:50
-
Torben Hansen commented on patch set 4 03/23/21, 14:51
InlineRecordContainer.php:619ReplyDonePagePositionMap.php:576ReplyDone -
TYPO3com voted on patch set 4 V +1 03/23/21, 14:57 Completed build in 07m 07s on Tue, 23 Mar, 02:57 PM Test Summary: 32910 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10314
-
core-ci voted on patch set 4 V +1 03/23/21, 15:01 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1789
-
Benni Mack voted on patch set 4 V +1 CR +1 03/23/21, 16:11
-
Georg Ringer voted on patch set 4 V +2 CR +2 03/24/21, 03:13
-
Georg Ringer merged patch set 5 03/24/21, 03:13