Review main Merged

68554[DOCS] Replace none working orderBy example

Daniel Siepmann CR +2 V +2 Easy +1 −1 updated 03/22/21, 19:06

Commit message

The given example does not work and is replaced by a working example.
Doctrine will add ASC as fallback sorting if no sorting direction is
given, leading to an invalid SQL.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Georg Ringer +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 1

Review log 612

  1. Daniel Siepmann uploaded patch set 1 03/22/21, 10:05

  2. TYPO3com voted on patch set 1 V +1 03/22/21, 10:12 Completed build in 07m 19s on Mon, 22 Mar, 10:12 AM Test Summary: 32907 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10278

  3. core-ci voted on patch set 1 V +1 03/22/21, 10:16 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1750

  4. Daniel Siepmann updated the commit message in patch set 2 03/22/21, 10:20

  5. Daniel Siepmann updated the commit message in patch set 3 03/22/21, 10:21

  6. TYPO3com voted on patch set 2 V +1 03/22/21, 10:28 Completed build in 07m 28s on Mon, 22 Mar, 10:28 AM Test Summary: 32907 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10279

  7. TYPO3com voted on patch set 3 V +1 03/22/21, 10:28 Completed build in 07m 21s on Mon, 22 Mar, 10:28 AM Test Summary: 32907 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10280

  8. core-ci voted on patch set 3 V +1 03/22/21, 10:34 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1752

  9. core-ci voted on patch set 2 V +1 03/22/21, 10:35 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1751

  10. Georg Ringer voted on patch set 3 V +1 CR +1 03/22/21, 12:52

  11. Daniel Goerz voted on patch set 3 V +2 CR +2 03/22/21, 19:06

  12. Daniel Goerz merged patch set 4 03/22/21, 19:06