Review main Merged

68556[BUGFIX] Check if property is null

Jonas Götze CR +2 V +2 Easy +3 −0 updated 04/23/21, 12:04

Commit message

ObjectAccess::getPropertyPath requires its second parameter to be string,
so it should not be called if the property argument is null
but return null instead as the getPropertyPath method would have done
in earlier versions.

Review

  • Code review CR +2 Done
    • Richard Haeser +2
    • Oliver Klee +1
    • Andreas Kienast +1
    • Mathias Brodala +1
  • Verified V +2 Done
    • Richard Haeser +2
    • Oli Bartsch +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 1

Review log 1521

  1. Jonas Götze uploaded patch set 1 03/22/21, 14:50

  2. TYPO3com voted on patch set 1 V +1 03/22/21, 14:57 Completed build in 07m 02s on Mon, 22 Mar, 02:57 PM Test Summary: 32907 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10286

  3. Mathias Brodala updated the commit message in patch set 2 03/22/21, 14:57

  4. Mathias Brodala commented on patch set 2 CR -1 03/22/21, 14:59

    AbstractFormFieldViewHelper.php:313

    This should be done as the first action in this method to skip pointless actions.
  5. core-ci voted on patch set 1 V +1 03/22/21, 15:01 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1760

  6. TYPO3com voted on patch set 2 V +1 03/22/21, 15:03 Completed build in 05m 43s on Mon, 22 Mar, 03:03 PM Test Summary: 32907 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10287

  7. core-ci voted on patch set 2 V +1 03/22/21, 15:07 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1761

  8. Jonas Götze uploaded patch set 3 03/22/21, 21:07

  9. Jonas Götze commented on patch set 3 03/22/21, 21:09

    AbstractFormFieldViewHelper.php:313 Reply

    Ack
  10. TYPO3com voted on patch set 3 V +1 03/22/21, 21:15 Completed build in 08m 16s on Mon, 22 Mar, 09:15 PM Test Summary: 32910 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10303

  11. core-ci voted on patch set 3 V +1 03/22/21, 21:18 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1776

  12. Mathias Brodala voted on patch set 3 CR +1 03/23/21, 07:38

  13. Oliver Klee commented on patch set 3 03/23/21, 11:13

    AbstractFormFieldViewHelper.php:299

    Will this always be set, or do we need to do an isset as well?
  14. Mathias Brodala commented on patch set 3 03/23/21, 11:19

    AbstractFormFieldViewHelper.php:299 Reply

    Registered Fluid viewhelper arguments always exist and use their default value (null by default) if not set on invocation.
  15. Mathias Brodala commented on patch set 3 03/23/21, 11:20

  16. Oliver Klee commented on patch set 3 CR +1 03/23/21, 12:33

    AbstractFormFieldViewHelper.php:299 Reply

    Thanks!
  17. Richard Haeser voted on patch set 3 V +1 CR +1 04/23/21, 07:52

  18. Oli Bartsch voted on patch set 3 V +1 04/23/21, 11:15

  19. Andreas Kienast voted on patch set 3 CR +1 04/23/21, 11:49

  20. Richard Haeser voted on patch set 3 V +2 CR +2 04/23/21, 12:04

  21. Richard Haeser merged patch set 4 04/23/21, 12:04