Review main Merged

68558[BUGFIX] Fix TypeError in PreviewUriBuilder

Oli Bartsch CR +2 V +2 Easy +1 −1 updated 03/22/21, 18:46

Commit message

With #91123 a new PreviewUriBuilder class was introduced.
This class features a factory method `create`, with a type
hinted parameter signature. This now leads to a TypeError
in EXT:workspaces, e.g. when importing datasets in tests.

This is fixed by typecasting the variable to be passed
to the factory method.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Oliver Klee +1
    • Benni Mack +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Benni Mack +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 1

Review log 57

  1. Oli Bartsch uploaded patch set 1 03/22/21, 16:15

  2. Benni Mack voted on patch set 1 V +1 CR +1 03/22/21, 16:22

  3. TYPO3com voted on patch set 1 V +1 03/22/21, 16:22 Completed build in 07m 09s on Mon, 22 Mar, 04:22 PM Test Summary: 32907 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10289

  4. core-ci voted on patch set 1 V +1 03/22/21, 16:25 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1763

  5. Oliver Klee voted on patch set 1 CR +1 03/22/21, 17:21

  6. Daniel Goerz voted on patch set 1 V +2 CR +2 03/22/21, 18:46

  7. Daniel Goerz merged patch set 2 03/22/21, 18:46