Review main Merged

68559[BUGFIX] Fix SVG tree height and toolbar in TCA select-tree

Benjamin Franzke CR +2 V +2 Easy +9 −3 updated 03/23/21, 20:30

Commit message

The previos flex-basis: auto setting caused the svg to grow
from it's initial size, which may be larger than the svg
tree container height. This caused visual overflows.
Fix this by start flex-growing zero based (flex-basis = 0).

Also ensure that the toolbar stays on top of the categories
while scrolling (position: sticky) and remove an invalid
flex-direction property (the svg-tree-wrapper used
display:block, therefore flex-direction has no effect).

Review

  • Code review CR +2 Done
    • Richard Haeser +2
    • Benni Mack +1
  • Verified V +2 Done
    • Richard Haeser +2
    • Benni Mack +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 2

Files 2

Review log 46

  1. Benjamin Franzke uploaded patch set 1 03/22/21, 19:05

  2. TYPO3com voted on patch set 1 V +1 03/22/21, 19:12 Completed build in 06m 56s on Mon, 22 Mar, 07:12 PM Test Summary: 32907 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10296

  3. Benni Mack voted on patch set 1 V +1 CR +1 03/22/21, 19:15

  4. core-ci voted on patch set 1 V +1 03/22/21, 19:18 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1769

  5. Richard Haeser voted on patch set 1 V +2 CR +2 03/22/21, 19:29

  6. Benjamin Franzke merged patch set 2 03/23/21, 20:30