Review main Merged

68560[BUGFIX] Ensure compared values are of same type

Oli Bartsch CR +2 V +2 Easy +14 −5 updated 03/24/21, 08:43

Commit message

When strict type comparison was introduced to
the OptionViewHelper in #90540, it was not properly
ensured that the values to compare are of same type.

The issue is fixed by always typecasting the selected
value to string, before comparing it to the value in
question, which will always be a string, according to
its type hint.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Oliver Klee +1
    • Jonas Eberle +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 2

Review log 68

  1. Oli Bartsch uploaded patch set 1 03/22/21, 21:02

  2. TYPO3com voted on patch set 1 V +1 03/22/21, 21:10 Completed build in 08m 04s on Mon, 22 Mar, 09:10 PM Test Summary: 32916 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10302

  3. core-ci voted on patch set 1 V +1 03/22/21, 21:14 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1775

  4. Oliver Klee voted on patch set 1 CR +1 03/23/21, 13:19

  5. Jonas Eberle voted on patch set 1 CR +1 03/23/21, 14:52

  6. Georg Ringer voted on patch set 1 V +1 CR +1 03/23/21, 16:11

  7. Benni Mack voted on patch set 1 V +2 CR +2 03/24/21, 08:43

  8. Benni Mack merged patch set 2 03/24/21, 08:43