Review main Merged

68562[BUGFIX] Keep top level upload folder

waldhacker CR +2 V +2 Easy +0 −7 updated 03/26/21, 16:49

Commit message

If a form upload is configured to save files within
"1:/user_upload/test/" (saveToFileMount: '1:/user_upload/test/'),
an upload will be saved within
"1:/user_upload/test/form_<random>/file.png".
Lateron, the DeleteUploadsFinisher delete
"1:/user_upload/test/form_<random>/file.png".
If "1:/user_upload/test/form_<random>/" is emty, this folder will be
deleted too.
This patch prevents the DeleteUploadsFinisher from trying to delete the
top level upload folder "1:/user_upload/test/".

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Mathias Brodala +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 1

Review log 68

  1. waldhacker uploaded patch set 1 03/23/21, 06:55

  2. TYPO3com voted on patch set 1 V +1 03/23/21, 07:03 Completed build in 07m 43s on Tue, 23 Mar, 07:03 AM Test Summary: 32910 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10306

  3. core-ci voted on patch set 1 V +1 03/23/21, 07:05 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1782

  4. Mathias Brodala voted on patch set 1 CR +1 03/23/21, 07:34

  5. Christian Kuhn voted on patch set 1 V +1 CR +1 03/26/21, 10:17

  6. Oli Bartsch voted on patch set 1 V +1 CR +1 03/26/21, 16:12

  7. Christian Kuhn voted on patch set 1 V +2 CR +2 03/26/21, 16:48

  8. Christian Kuhn merged patch set 2 03/26/21, 16:49