Review main Merged

68563[BUGFIX] Fix content element preview for menu types

Oli Bartsch CR +2 V +2 Normal +43 −30 updated 03/24/21, 08:50

Commit message

With the introduction of fluid styled content in #79622,
the former CType `menu` with its subtypes was splitted
into dedicated content types. Since the content element
preview was not adjusted, it still checked for the `menu`
CType, which did not longer exist in Core, leading to no
preview for any menu type was displayed in page module.

The issue is fixed by adjusting the code to check for the
correct content types, making the preview work again.

This also replaces the last usages of LLL:EXT:lang.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 1

Review log 913

  1. Oli Bartsch uploaded patch set 1 03/23/21, 11:19

  2. TYPO3com voted on patch set 1 V +1 03/23/21, 11:27 Completed build in 07m 58s on Tue, 23 Mar, 11:27 AM Test Summary: 32910 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10309

  3. core-ci voted on patch set 1 V +1 03/23/21, 11:30 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1785

  4. Georg Ringer commented on patch set 1 03/23/21, 12:48

    StandardContentPreviewRenderer.php:196

    i don't like that, 3rd party menus shouldn't be handled
  5. Oli Bartsch commented on patch set 1 03/23/21, 13:57

    StandardContentPreviewRenderer.php:196 Reply

    So what's your suggestion?
  6. Georg Ringer commented on patch set 1 03/23/21, 14:13

    StandardContentPreviewRenderer.php:196 Reply

    using in_array and check for all of core's menu ctypes
  7. Oli Bartsch uploaded patch set 2 03/23/21, 14:32

  8. Oli Bartsch commented on patch set 2 03/23/21, 14:34

    StandardContentPreviewRenderer.php:196 Reply

    Done
  9. TYPO3com voted on patch set 2 V +1 03/23/21, 14:38 Completed build in 06m 26s on Tue, 23 Mar, 02:38 PM Test Summary: 32910 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10313

  10. core-ci voted on patch set 2 V +1 03/23/21, 14:42 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1788

  11. Georg Ringer voted on patch set 2 V +1 CR +1 03/23/21, 14:51

  12. Benni Mack voted on patch set 2 V +2 CR +2 03/24/21, 08:50

  13. Benni Mack merged patch set 3 03/24/21, 08:50