Review main Merged

68573[TASK] Enable phpstan checkArgumentsPassedByReference check

Daniel Goerz CR +2 V +2 Easy +16 −7 updated 03/24/21, 19:46

Commit message

Whenever methods take arguments by reference only variables
may be passed. This patch activates the corresponding phpstan
check and fixes all places in the core.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Oli Bartsch +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Oli Bartsch +1
    • Christian Kuhn +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 5

Review log 711

  1. Daniel Goerz uploaded patch set 1 03/23/21, 18:32

  2. Daniel Goerz wrote 03/23/21, 18:33

    Topic set to phpstan
  3. TYPO3com voted on patch set 1 V -1 03/23/21, 18:39 Completed build in 07m 09s on Tue, 23 Mar, 06:39 PM Test Summary: 2 of 33146 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10317

  4. core-ci voted on patch set 1 V -1 03/23/21, 18:43 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1792

  5. Daniel Goerz uploaded patch set 2 03/24/21, 08:28

  6. TYPO3com voted on patch set 2 V +1 03/24/21, 08:35 Completed build in 06m 23s on Wed, 24 Mar, 08:35 AM Test Summary: 32910 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10323

  7. core-ci voted on patch set 2 V +1 03/24/21, 08:39 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1801

  8. Christian Kuhn voted on patch set 2 V +1 CR +1 03/24/21, 14:58

  9. Oli Bartsch voted on patch set 2 V +1 CR +1 03/24/21, 15:02

  10. Daniel Goerz voted on patch set 2 V +2 CR +2 03/24/21, 19:46

  11. Daniel Goerz merged patch set 3 03/24/21, 19:46