Review main Merged

68576[TASK] Update @types/bootstrap

Oli Bartsch CR +2 V +2 Normal +59 −22 updated 03/25/21, 14:00

Commit message

In #93810 bootstrap was updated to 5.0.0-beta3,
which contains the new "offcanvas" component.

In order to use it in TypeScript, we need to update
the corresponding type definitions.

The new type definition doo not define return types for
bootstrap JQuery methods, therefore we simply avoid
usage of these.
The update additionally revealed one bug in the login
screen, where the login-submit button did not longer
show a loading indicator as $.button('loading') is no
longer available in bootstrap 5.
This issue is fixed as a drive-by change.

Also @types/jqueryui needs to be patched as the tooltip and
button definitions conflict with those from @bootstrap/types.

Executed command:

  yarn add --dev @types/bootstrap
  yarn patch-package @types/jqueryui

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Benjamin Franzke +1
    • Oli Bartsch +1
  • Verified V +2 Done
    • Benni Mack +2
    • Benjamin Franzke +1
    • Oli Bartsch +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 10

Review log 914

  1. Oli Bartsch uploaded patch set 1 03/24/21, 16:03

  2. Benni Mack voted on patch set 1 V +1 CR +1 03/24/21, 16:04

  3. TYPO3com voted on patch set 1 V -1 03/24/21, 16:11 Completed build in 07m 50s on Wed, 24 Mar, 04:11 PM Test Summary: 32916 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10330

  4. TYPO3com commented on patch set 1 03/24/21, 16:14 Completed build in 18m 50s on Wed, 24 Mar, 04:14 PM Test Summary: 32916 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10330

  5. core-ci voted on patch set 1 V -1 03/24/21, 16:14 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1811

  6. Oli Bartsch commented on patch set 1 CR -1 03/24/21, 18:04

    This currently conflicts with our own type definition (Build/types/TYPO3/index.d.ts).
  7. Benni Mack voted on patch set 1 V 0 CR 0 03/24/21, 22:02

  8. Benjamin Franzke uploaded patch set 2 03/25/21, 10:35

  9. TYPO3com voted on patch set 2 V +1 03/25/21, 10:43 Completed build in 07m 10s on Thu, 25 Mar, 10:43 AM Test Summary: 33204 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10343

  10. core-ci voted on patch set 2 V +1 03/25/21, 10:46 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1828

  11. Oli Bartsch voted on patch set 2 V +1 CR +1 03/25/21, 11:05

  12. Benni Mack commented on patch set 2 V +2 CR +2 03/25/21, 11:58

    next up: get rid of jquery ui :D
  13. Benni Mack merged patch set 3 03/25/21, 11:58

  14. Benjamin Franzke commented on patch set 3 03/25/21, 14:00

    Reply

    definitely, that's actually why I added the jquery-ui patch, because I think it's an OK approach, as we want to get rid of jquery-ui anyway, so the patch will (hopefully) not be there "forever".