68576[TASK] Update @types/bootstrap
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Benjamin Franzke +1
- Oli Bartsch +1
-
Verified V +2 Done
- Benni Mack +2
- Benjamin Franzke +1
- Oli Bartsch +1
- TYPO3com +1 CI
- core-ci +1 CI
Issues 1
Files 10
- Build/patches/@types+jqueryui+1.12.13.patchnew+43 −0
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/AjaxDataHandler.ts+2 −1
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/Login.ts+2 −1
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/Modal.ts+2 −1
- Build/types/TYPO3/index.d.ts+0 −9
- Build/package.json+1 −1
- Build/yarn.lock+6 −6
- typo3/sysext/backend/Resources/Public/JavaScript/AjaxDataHandler.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/Login.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/Modal.js+1 −1
Review log 914
-
Oli Bartsch uploaded patch set 1 03/24/21, 16:03
-
Benni Mack voted on patch set 1 V +1 CR +1 03/24/21, 16:04
-
TYPO3com voted on patch set 1 V -1 03/24/21, 16:11 Completed build in 07m 50s on Wed, 24 Mar, 04:11 PM Test Summary: 32916 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10330
-
TYPO3com commented on patch set 1 03/24/21, 16:14 Completed build in 18m 50s on Wed, 24 Mar, 04:14 PM Test Summary: 32916 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10330
-
core-ci voted on patch set 1 V -1 03/24/21, 16:14 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1811
-
Oli Bartsch commented on patch set 1 CR -1 03/24/21, 18:04
This currently conflicts with our own type definition (Build/types/TYPO3/index.d.ts). -
Benni Mack voted on patch set 1 V 0 CR 0 03/24/21, 22:02
-
Benjamin Franzke uploaded patch set 2 03/25/21, 10:35
-
TYPO3com voted on patch set 2 V +1 03/25/21, 10:43 Completed build in 07m 10s on Thu, 25 Mar, 10:43 AM Test Summary: 33204 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10343
-
core-ci voted on patch set 2 V +1 03/25/21, 10:46 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1828
-
Oli Bartsch voted on patch set 2 V +1 CR +1 03/25/21, 11:05
-
Benni Mack commented on patch set 2 V +2 CR +2 03/25/21, 11:58
next up: get rid of jquery ui :D -
Benni Mack merged patch set 3 03/25/21, 11:58
-
Benjamin Franzke commented on patch set 3 03/25/21, 14:00
Reply
definitely, that's actually why I added the jquery-ui patch, because I think it's an OK approach, as we want to get rid of jquery-ui anyway, so the patch will (hopefully) not be there "forever".