Review main Merged

68613[BUGFIX] Check for correct languageField in unique evaluation

Christoph Lehmann CR +2 V +2 Easy +1 −1 updated 03/25/21, 12:02

Commit message

The languageField property is configured in TCA ctrl section and not in a TCA field.

With this commit re-editing a record in default language does not change the value
of a field with unique evaluation when the field has l10n_mode=exclude.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Jonas Eberle +1
    • Guido Schmechel +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 1

Review log 79

  1. Christoph Lehmann uploaded patch set 1 03/25/21, 11:07

  2. TYPO3com voted on patch set 1 V +1 03/25/21, 11:16 Completed build in 07m 57s on Thu, 25 Mar, 11:16 AM Test Summary: 33202 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10344

  3. core-ci voted on patch set 1 V +1 03/25/21, 11:20 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1830

  4. Jonas Eberle voted on patch set 1 CR +1 03/25/21, 11:23

  5. Christian Kuhn voted on patch set 1 CR +1 03/25/21, 11:34

  6. Oli Bartsch voted on patch set 1 V +1 CR +1 03/25/21, 11:38

  7. Guido Schmechel voted on patch set 1 CR +1 03/25/21, 11:43

  8. Benni Mack voted on patch set 1 V +2 CR +2 03/25/21, 12:02

  9. Benni Mack merged patch set 2 03/25/21, 12:02