Review main Merged

68616[BUGFIX] Fix descriptions of selectCheckBox items

Oli Bartsch CR +2 V +2 Normal +107 −31 updated 03/29/21, 08:53

Commit message

With #91008 the grouping and sorting feature was
introduced to the TCA select type. As a consequence,
the select items array key for the help text changed
from `3` to `4`.

The SelectCheckBox now correctly checks the `4`
key for the presence of a description.

In v11 the absence of a title value, which is common
in this scenario, did furthermore lead to TypeError
on rendering the popover. This is fixed by assigning
an empty string as default value on initialization of
the popover options. Otherwise this option would be
initialized as 'undefined' and then trigger the
TypeError on sanitizing.

Additionally the TCA properties special=table,
special=exclude and special=custom are adjusted to
add the correct value as help text to the items array.
The value is now added directly as string, as there
is no need to define the array while only providing
the description.

As a drive-by-change, the itemsProcFuncs of the
dashboard and the MFA component do now also add
the description for their access list field. This
is done because the dashboard initially defined the
description already but had to remove it again due
to this bug, see: #91152. The MFA component also
just hadn't added it because the bug hadn't been
resolved at that time.

Review

  • Code review CR +2 Done
    • Richard Haeser +2
    • Julian Mair +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Richard Haeser +2
    • Christian Kuhn +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 2

Files 10

Review log 1120

  1. Oli Bartsch uploaded patch set 1 03/26/21, 12:05

  2. Oli Bartsch updated the commit message in patch set 2 03/26/21, 12:11

  3. TYPO3com voted on patch set 1 V -1 03/26/21, 12:13 Completed build in 07m 32s on Fri, 26 Mar, 12:13 PM Test Summary: 32831 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10363

  4. core-ci voted on patch set 1 V +1 03/26/21, 12:16 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1852

  5. TYPO3com voted on patch set 2 V -1 03/26/21, 12:18 Completed build in 06m 57s on Fri, 26 Mar, 12:18 PM Test Summary: 32454 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10364

  6. core-ci voted on patch set 2 V +1 03/26/21, 12:21 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1853

  7. TYPO3com voted on patch set 2 V +1 03/26/21, 12:23 Completed build in 18m 36s on Fri, 26 Mar, 12:23 PM Test Summary: 33239 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10364

  8. Julian Mair voted on patch set 2 CR +1 03/26/21, 12:39

  9. Christian Kuhn voted on patch set 2 V +1 CR +1 03/26/21, 13:00

  10. Oli Bartsch commented on patch set 2 CR -1 03/26/21, 14:46

    Changing a detail.
  11. Oli Bartsch uploaded patch set 3 03/26/21, 16:01

  12. TYPO3com voted on patch set 3 V -1 03/26/21, 16:09 Completed build in 07m 02s on Fri, 26 Mar, 04:09 PM Test Summary: 32868 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10367

  13. Oli Bartsch updated the commit message in patch set 4 03/26/21, 16:10

  14. core-ci voted on patch set 3 V +1 03/26/21, 16:13 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1862

  15. TYPO3com voted on patch set 4 V +1 03/26/21, 16:17 Completed build in 07m 04s on Fri, 26 Mar, 04:17 PM Test Summary: 33257 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10368

  16. core-ci voted on patch set 4 V +1 03/26/21, 16:20 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1863

  17. Julian Mair voted on patch set 4 CR +1 03/26/21, 16:23

  18. Christian Kuhn voted on patch set 4 V +1 CR +1 03/26/21, 16:43

  19. Richard Haeser voted on patch set 4 V +2 CR +2 03/29/21, 08:53

  20. Richard Haeser merged patch set 5 03/29/21, 08:53