Review 10.4 Merged

68617[TASK] Check maximum PHP version in entrypoints

Christian Kuhn CR +2 V +2 Easy +11 −6 updated 03/26/21, 15:21

Commit message

This adds another safeguard to prevent running TYPO3 on unsupported PHP
versions.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Mathias Brodala +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Mathias Brodala +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 4

Review log 714

  1. Christian Kuhn uploaded patch set 1 03/26/21, 14:54

  2. Mathias Brodala commented on patch set 1 CR -1 03/26/21, 14:56

    backend.php:18 Unresolved

    There should be a space after the operator.

    cli.php:18 Unresolved

    This must be 7.2
  3. Christian Kuhn uploaded patch set 2 03/26/21, 14:59

  4. TYPO3com voted on patch set 1 V +1 03/26/21, 15:02 Completed build in 07m 46s on Fri, 26 Mar, 03:02 PM Test Summary: 75930 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1267

  5. Mathias Brodala uploaded patch set 3 03/26/21, 15:04

  6. Mathias Brodala voted on patch set 3 V +1 CR +1 03/26/21, 15:06

  7. TYPO3com voted on patch set 2 V +1 03/26/21, 15:07 Completed build in 07m 52s on Fri, 26 Mar, 03:07 PM Test Summary: 75930 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1268

  8. core-ci voted on patch set 1 V +1 03/26/21, 15:08 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1857

  9. core-ci voted on patch set 2 V +1 03/26/21, 15:11 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1858

  10. TYPO3com voted on patch set 3 V -1 03/26/21, 15:11 Completed build in 07m 21s on Fri, 26 Mar, 03:11 PM Test Summary: 75566 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1269

  11. core-ci voted on patch set 3 V +1 03/26/21, 15:15 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1859

  12. TYPO3com voted on patch set 3 V +1 03/26/21, 15:17 Completed build in 21m 02s on Fri, 26 Mar, 03:17 PM Test Summary: 75930 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1269

  13. Christian Kuhn voted on patch set 3 V +2 CR +2 03/26/21, 15:21

  14. Christian Kuhn merged patch set 4 03/26/21, 15:21