Review main Merged

68622[TASK] Deprecate special property of TCA type select

Oli Bartsch CR +2 V +2 Nightmare +1329 −1256 updated 04/01/21, 09:57

Commit message

In #57082 the special=languages option was migrated to the
new TCA type "language". The remaining options for "special"
are mainly used for be_users and be_groups only and can
also be implemented as `itemsProcFunc` functions. This reduces
unnecessary complexity for the TCA "select" type.

Therefore, this patch migrates all remaining options of the
"special" property to dedicated itemsProcFunc's and deprecates
the use of this property along with the corresponding
`addItemsFromSpecial` method in AbstractItemProvider.

Since the remaining options are mainly used internally, the new
class, containing the itemsProcFunc's, is marked as internal.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 10

Review log 1329

Show 24 earlier messages
  1. Oli Bartsch uploaded patch set 1 03/26/21, 23:54

  2. TYPO3com voted on patch set 1 V +1 03/27/21, 00:01 Completed build in 06m 26s on Sat, 27 Mar, 12:01 AM Test Summary: 33257 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10375

  3. core-ci voted on patch set 1 V +1 03/27/21, 00:05 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1872

  4. Oli Bartsch uploaded patch set 2 03/30/21, 09:05

  1. TYPO3com voted on patch set 2 V +1 03/30/21, 09:12 Completed build in 06m 47s on Tue, 30 Mar, 09:12 AM Test Summary: 33263 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10390

  2. core-ci voted on patch set 2 V +1 03/30/21, 09:16 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1904

  3. Oli Bartsch uploaded patch set 3 03/31/21, 10:38

  4. TYPO3com voted on patch set 3 V -1 03/31/21, 10:45 Completed build in 06m 45s on Wed, 31 Mar, 10:45 AM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10404

  5. core-ci voted on patch set 3 V -1 03/31/21, 10:48 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1928

  6. Oli Bartsch uploaded patch set 4 03/31/21, 13:26

  7. TYPO3com voted on patch set 4 V -1 03/31/21, 13:33 Completed build in 06m 39s on Wed, 31 Mar, 01:33 PM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10408

  8. core-ci voted on patch set 4 V -1 03/31/21, 13:36 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1933

  9. Oli Bartsch uploaded patch set 5 03/31/21, 13:43

  10. TYPO3com voted on patch set 5 V +1 03/31/21, 13:51 Completed build in 07m 48s on Wed, 31 Mar, 01:51 PM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10410

  11. core-ci voted on patch set 5 V +1 03/31/21, 13:54 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1935

  12. Oli Bartsch uploaded patch set 6 03/31/21, 14:01

  13. TYPO3com voted on patch set 6 V +1 03/31/21, 14:09 Completed build in 08m 21s on Wed, 31 Mar, 02:09 PM Test Summary: 33265 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10413

  14. Christian Kuhn commented on patch set 6 03/31/21, 14:16

    be_groups.php:210

    I'd prefer to net 'invent' a new array key here. Instead, we could have two different itemProcFunc's that dispatch the work to a common method that has a user/group argument? What do you think?
  15. core-ci voted on patch set 6 V +1 03/31/21, 14:16 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1938

  16. Oli Bartsch uploaded patch set 7 03/31/21, 19:08

  17. TYPO3com voted on patch set 7 V +1 03/31/21, 19:15 Completed build in 07m 14s on Wed, 31 Mar, 07:15 PM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10419

  18. core-ci voted on patch set 7 V +1 03/31/21, 19:19 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1943

  19. Oli Bartsch uploaded patch set 8 03/31/21, 19:33

  20. Oli Bartsch commented on patch set 8 03/31/21, 19:34

    be_groups.php:210 Reply

    Done
  21. TYPO3com voted on patch set 8 V +1 03/31/21, 19:40 Completed build in 07m 13s on Wed, 31 Mar, 07:40 PM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10420

  22. core-ci voted on patch set 8 V +1 03/31/21, 19:44 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1944

  23. Christian Kuhn voted on patch set 8 V +1 CR +1 04/01/21, 07:53

  24. Benni Mack voted on patch set 8 V +2 CR +2 04/01/21, 09:57

  25. Benni Mack merged patch set 9 04/01/21, 09:57