Review main Merged

68625[BUGFIX] Support whitespace in TypoScript getData file: usage

Daniel Siepmann CR +2 V +2 Easy +19 −3 updated 03/30/21, 09:46

Commit message

getText supports whitespaces in its syntax, e.g. `file : 17 : size`.
That was not respected when using in combination with file.
This has been fixed by using `GeneralUtility::trimExplode()`.

Review

  • Code review CR +2 Done
    • Richard Haeser +2
    • Christian Kuhn +2
    • Mathias Brodala +1
  • Verified V +2 Done
    • Richard Haeser +2
    • Christian Kuhn +2
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 2

Review log 1424

  1. Daniel Siepmann uploaded patch set 1 03/29/21, 12:02

  2. TYPO3com voted on patch set 1 V -1 03/29/21, 12:13 Completed build in 10m 02s on Mon, 29 Mar, 12:12 PM Test Summary: 33265 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10381

  3. core-ci voted on patch set 1 V -1 03/29/21, 12:15 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1891

  4. Daniel Siepmann uploaded patch set 2 03/29/21, 12:17

  5. Daniel Siepmann uploaded patch set 3 03/29/21, 12:19

  6. TYPO3com voted on patch set 2 V +1 03/29/21, 12:23 Completed build in 06m 11s on Mon, 29 Mar, 12:23 PM Test Summary: 33265 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10382

  7. TYPO3com voted on patch set 3 V +1 03/29/21, 12:25 Completed build in 06m 35s on Mon, 29 Mar, 12:25 PM Test Summary: 33265 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10383

  8. core-ci voted on patch set 2 V +1 03/29/21, 12:28 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1893

  9. Mathias Brodala commented on patch set 3 03/29/21, 12:28

    ContentObjectRendererTest.php:1260

    You could use a dataprovider or @testWith instead of a separate test which is 99% the same.
  10. core-ci voted on patch set 3 V +1 03/29/21, 12:29 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1894

  11. Daniel Siepmann uploaded patch set 4 03/29/21, 12:32

  12. Daniel Siepmann commented on patch set 4 03/29/21, 12:32

    ContentObjectRendererTest.php:1260 Reply

    Done
  13. TYPO3com voted on patch set 4 V +1 03/29/21, 12:39 Completed build in 07m 11s on Mon, 29 Mar, 12:39 PM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10384

  14. Richard Haeser voted on patch set 4 CR +1 03/29/21, 12:42

  15. Mathias Brodala voted on patch set 4 CR +1 03/29/21, 12:42

  16. core-ci voted on patch set 4 V +1 03/29/21, 12:43 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1895

  17. Christian Kuhn uploaded patch set 5 03/29/21, 12:45

  18. Mathias Brodala voted on patch set 5 CR +1 03/29/21, 12:48

  19. TYPO3com voted on patch set 5 V +1 03/29/21, 12:52 Completed build in 07m 05s on Mon, 29 Mar, 12:52 PM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10386

  20. Christian Kuhn voted on patch set 5 V +1 CR +1 03/29/21, 12:53

  21. core-ci voted on patch set 5 V +1 03/29/21, 12:54 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1897

  22. Richard Haeser voted on patch set 5 V +2 CR +2 03/29/21, 12:59

  23. Christian Kuhn voted on patch set 5 V +2 CR +2 03/30/21, 09:46

  24. Christian Kuhn merged patch set 6 03/30/21, 09:46