Review 10.4 Merged

68633[BUGFIX] Exclude language "All" from available translation source languages

Christian Kuhn CR +2 V +2 Easy +6 −0 updated 03/26/21, 13:10

Commit message

Records in language "All" are not translatable by definition. Therefore
this language must not be allowed as a source language for translations
in UI. This fix removes language "All" from the translation wizard.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 1

Review log 57

  1. Christian Kuhn commented on patch set 1 03/26/21, 10:15

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 03/26/21, 10:23 Completed build in 07m 56s on Fri, 26 Mar, 10:23 AM Test Summary: 75909 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1262

  3. core-ci voted on patch set 1 V +1 03/26/21, 10:26 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1849

  4. Christian Kuhn voted on patch set 1 V +2 CR +2 03/26/21, 10:28

  5. Christian Kuhn commented on patch set 1 V +1 CR +1 03/26/21, 10:34

    note, scenario in master and in v10 (with fluid base page module enabled): have another content element in default language set to -1 -> the 'translate' button is always shown, the popup then doesn't do much and fails in last step. --> yet another issue with the translate button in fluid based page module ... should be fixed as separate patch.
  6. Christian Kuhn voted on patch set 1 V +2 CR +2 03/26/21, 13:09

  7. Christian Kuhn merged patch set 2 03/26/21, 13:10