Review 10.4 Merged

68635[BUGFIX] Render canonical link of target page when page is in mountpoint

Richard Haeser CR +2 V +2 Normal +152 −2 updated 03/26/21, 14:38

Commit message

When a page is within a mountpoint, the normal behaviour is to generate
a link within the mountpoint. As the content is shown from another page,
the url of the target page is necessary as a canonical to avoid
duplicate content. To do this, we temporarily remove the mountpoint
information while creating the canonical link which results in the
link to the target page.

Review

  • Code review CR +2 Done
    • Richard Haeser +2
  • Verified V +2 Done
    • Richard Haeser +2
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 4

Review log 510

  1. Richard Haeser commented on patch set 1 03/26/21, 14:13

    Cherry Picked from branch master. The following files contain Git conflicts: * typo3/sysext/seo/Tests/Functional/Canonical/CanonicalGeneratorTest.php * typo3/sysext/seo/Tests/Functional/Fixtures/Canonical.typoscript * typo3/sysext/seo/Tests/Functional/Fixtures/pages-canonical.xml
  2. TYPO3com voted on patch set 1 V -1 03/26/21, 14:15 Completed build in 01m 01s on Fri, 26 Mar, 02:14 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1264

  3. core-ci voted on patch set 1 V -1 03/26/21, 14:15 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1855

  4. Richard Haeser uploaded patch set 2 03/26/21, 14:21

  5. Richard Haeser commented on patch set 2 03/26/21, 14:21

    This change is ready for review.
  6. TYPO3com voted on patch set 2 V -1 03/26/21, 14:29 Completed build in 07m 44s on Fri, 26 Mar, 02:29 PM Test Summary: 75469 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1265

  7. core-ci voted on patch set 2 V +1 03/26/21, 14:33 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1856

  8. TYPO3com voted on patch set 2 V +1 03/26/21, 14:38 Completed build in 07m 36s on Fri, 26 Mar, 02:38 PM Test Summary: 75930 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1266

  9. Richard Haeser voted on patch set 2 V +2 CR +2 03/26/21, 14:38

  10. Richard Haeser merged patch set 3 03/26/21, 14:38