Review 10.4 Merged

68654[BUGFIX] Support whitespace in TypoScript getData file: usage

Christian Kuhn CR +2 V +2 Easy +19 −3 updated 03/30/21, 10:09

Commit message

getText supports whitespaces in its syntax, e.g. `file : 17 : size`.
That was not respected when using in combination with file.
This has been fixed by using `GeneralUtility::trimExplode()`.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 2

Review log 35

  1. Christian Kuhn uploaded patch set 1 03/30/21, 09:47

  2. TYPO3com voted on patch set 1 V +1 03/30/21, 09:54 Completed build in 07m 22s on Tue, 30 Mar, 09:54 AM Test Summary: 75948 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1281

  3. core-ci voted on patch set 1 V +1 03/30/21, 10:02 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1908

  4. Christian Kuhn voted on patch set 1 V +2 CR +2 03/30/21, 10:09

  5. Christian Kuhn merged patch set 2 03/30/21, 10:09