Review main Merged

68655[TASK] Update comment removing unused "transport_smtp_port"

TYPO3com CR +2 V +2 Easy +1 −2 updated 03/30/21, 12:00

Commit message

Fix a broken comment mentioning transport_smtp_port,
it was never used within TYPO3 core. Introduced way back
in 2010, it already documented that the server port has
to be written within transport_smtp_server with a colon.
Update the line of transport_smtp_server to a proper
example by adding colon and port.

Review

  • Code review CR +2 Done
    • Richard Haeser +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Richard Haeser +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 613

  1. TYPO3com uploaded patch set 1 03/30/21, 10:57

  2. TYPO3com voted on patch set 1 V +1 03/30/21, 11:04 Completed build in 06m 48s on Tue, 30 Mar, 11:04 AM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10391

  3. core-ci voted on patch set 1 V +1 03/30/21, 11:08 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1909

  4. Christian Kuhn uploaded patch set 2 03/30/21, 11:42

  5. Christian Kuhn updated the commit message in patch set 3 03/30/21, 11:43

  6. Christian Kuhn voted on patch set 3 V +1 CR +1 03/30/21, 11:44

  7. Richard Haeser voted on patch set 3 V +1 CR +1 03/30/21, 11:45

  8. TYPO3com voted on patch set 2 V +1 03/30/21, 11:50 Completed build in 07m 10s on Tue, 30 Mar, 11:50 AM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10392

  9. TYPO3com voted on patch set 3 V +1 03/30/21, 11:50 Completed build in 06m 15s on Tue, 30 Mar, 11:50 AM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10393

  10. Richard Haeser voted on patch set 3 V +2 CR +2 03/30/21, 11:50

  11. Richard Haeser merged patch set 4 03/30/21, 11:50

  12. core-ci voted on patch set 2 V +1 03/30/21, 11:55 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1910

  13. core-ci voted on patch set 3 V +1 03/30/21, 12:00 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1911