Review main Merged

68656[BUGFIX] Fixed @return annotation

TYPO3com CR +2 V +2 Easy +17 −6 updated 04/27/21, 21:43

Commit message

current() returns FALSE if array is empty or internal array pointer is
beyond the end.

Without this change, this currently leads to the following exception:

Return value of TYPO3\CMS\Extbase\Error\Result::getFirstError() must be an
instance of TYPO3\CMS\Extbase\Error\Error, bool returned

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 612

  1. TYPO3com uploaded patch set 1 03/30/21, 13:02

  2. TYPO3com voted on patch set 1 V +1 03/30/21, 13:08 Completed build in 06m 26s on Tue, 30 Mar, 01:08 PM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10395

  3. core-ci voted on patch set 1 V +1 03/30/21, 13:13 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1915

  4. Benni Mack uploaded patch set 2 04/27/21, 21:04

  5. Benni Mack updated the commit message in patch set 3 04/27/21, 21:05

  6. core-ci voted on patch set 2 V -1 04/27/21, 21:06 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10792

  7. core-ci voted on patch set 3 V -1 04/27/21, 21:07 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10793

  8. Benni Mack uploaded patch set 4 04/27/21, 21:15

  9. core-ci voted on patch set 4 V +1 04/27/21, 21:27 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10795

  10. Christian Kuhn voted on patch set 4 V +1 CR +1 04/27/21, 21:36

  11. Daniel Goerz voted on patch set 4 V +2 CR +2 04/27/21, 21:43

  12. Daniel Goerz merged patch set 5 04/27/21, 21:43