Review main Abandoned

68661[TASK] Deny doctrine/dbal 2.13

Christian Kuhn CR 0 V 0 Easy +5 −5 updated 04/01/21, 15:36

Commit message

New doctrine/dbal 2.13.0 collides with core master:
Return value of TYPO3\CMS\Core\Database\Connection::select() must
implement interface Doctrine\DBAL\Driver\Statement, instance of
Doctrine\DBAL\ForwardCompatibility\Result returned

We'll restrict to 2.12.x for now:
composer req doctrine/dbal:"~2.12.0"

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 5

Review log 1115

  1. Christian Kuhn uploaded patch set 1 03/31/21, 10:12

  2. TYPO3com voted on patch set 1 V -1 03/31/21, 10:19 Completed build in 06m 51s on Wed, 31 Mar, 10:19 AM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10403

  3. Benni Mack commented on patch set 1 03/31/21, 10:22

    Wouldn't you agree that their 2.13.x release is a breaking change?
  4. core-ci voted on patch set 1 V -1 03/31/21, 10:23 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1927

  5. Christian Kuhn uploaded patch set 2 03/31/21, 11:07

  6. TYPO3com voted on patch set 2 V +1 03/31/21, 11:14 Completed build in 06m 51s on Wed, 31 Mar, 11:14 AM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10405

  7. core-ci voted on patch set 2 V +1 03/31/21, 11:18 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1929

  8. Xavier Perseguers voted on patch set 2 V +1 CR +1 03/31/21, 11:19

  9. Christian Kuhn commented on patch set 2 03/31/21, 12:12

    benni is currently looking if that could be done differently.
  10. Richard Haeser voted on patch set 2 V +2 CR +2 03/31/21, 12:16

  11. Richard Haeser voted on patch set 2 V 0 CR 0 03/31/21, 12:16

  12. Richard Haeser commented on patch set 2 03/31/21, 12:17

    Waiting for benni
  13. Susi Moog voted on patch set 2 V +1 04/01/21, 06:08

  14. Christian Kuhn commented on patch set 2 CR -1 04/01/21, 09:15

    Benni is working on 2.13 compat ... maybe this patch is not needed.
  15. Christian Kuhn abandoned the change 04/01/21, 15:36

    abandoned in favor of #93848