Review main Abandoned

68662[BUGFIX] symfony/mailer escapes surrounding doubleticks

Christian Kuhn CR 0 V 0 Easy +24 −9 updated 05/03/21, 10:47

Commit message

symfony/mime 5.5.6 and 4.4.21 double escape addresses
if they are given as "aName" (with the doubleticks)
to "\"aName\"".

The patch solves this in cases where our MailMessage
fassade is used and an address in not hand over as a
final Address object.

It only works partially, though.

Review

  • Code review CR 0
  • Verified V 0

Issues 2

Files 3

Review log 57

  1. Christian Kuhn uploaded patch set 1 03/31/21, 13:14

  2. Christian Kuhn commented on patch set 1 CR -2 03/31/21, 13:15

    we can only half-fix that ... maybe, it's better to revert the patches for #93831 and set these versions as conflict until symfony took care of the issue.
  3. TYPO3com voted on patch set 1 V +1 03/31/21, 13:21 Completed build in 06m 31s on Wed, 31 Mar, 01:21 PM Test Summary: 33277 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10407

  4. core-ci voted on patch set 1 V +1 03/31/21, 13:24 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1932

  5. Christian Kuhn commented on patch set 1 04/01/21, 10:11

    on hold for now.
  6. Christian Kuhn commented on patch set 1 05/03/21, 10:47

  7. Christian Kuhn abandoned the change 05/03/21, 10:47