68663[FEATURE] Allow user to disable CSH
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 6
- typo3/sysext/backend/Classes/Utility/BackendUtility.php2+3 −1
- typo3/sysext/core/Classes/Authentication/BackendUserAuthentication.php+1 −0
- typo3/sysext/core/Documentation/Changelog/master/Feature-93845-AllowUserToDisableCSH.rst4new+26 −0
- typo3/sysext/setup/Resources/Private/Language/locallang.xlf+3 −0
- typo3/sysext/setup/ext_tables.php1+5 −2
- typo3/sysext/t3editor/Resources/Public/JavaScript/Mode/typoscript/typoscript.js+1 −0
Review log 2038
Show 513 earlier messages
-
Eric Chavaillaz uploaded patch set 1 03/31/21, 13:59
-
Eric Chavaillaz uploaded patch set 2 03/31/21, 14:00
-
TYPO3com voted on patch set 1 V -1 03/31/21, 14:06 Completed build in 07m 07s on Wed, 31 Mar, 02:06 PM Test Summary: 6 of 33503 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10411
-
TYPO3com voted on patch set 2 V -1 03/31/21, 14:07 Completed build in 06m 37s on Wed, 31 Mar, 02:07 PM Test Summary: 6 of 33503 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10412
-
core-ci voted on patch set 1 V -1 03/31/21, 14:12 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1936
-
core-ci voted on patch set 2 V -1 03/31/21, 14:15 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1937
-
Eric Chavaillaz uploaded patch set 3 03/31/21, 14:22
-
Eric Chavaillaz updated the commit message in patch set 4 03/31/21, 14:27
-
TYPO3com voted on patch set 3 V -1 03/31/21, 14:29 Completed build in 06m 29s on Wed, 31 Mar, 02:29 PM Test Summary: 6 of 33503 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10415
-
core-ci voted on patch set 3 V -1 03/31/21, 14:34 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1939
-
TYPO3com voted on patch set 4 V -1 03/31/21, 14:34 Completed build in 06m 36s on Wed, 31 Mar, 02:34 PM Test Summary: 6 of 33503 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10416
-
core-ci voted on patch set 4 V -1 03/31/21, 14:39 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1940
-
Eric Chavaillaz uploaded patch set 5 03/31/21, 14:47
-
TYPO3com voted on patch set 5 V -1 03/31/21, 14:48 Completed build in 18s on Wed, 31 Mar, 02:48 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10417
-
core-ci voted on patch set 5 V -1 03/31/21, 14:49 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1941
-
Eric Chavaillaz uploaded patch set 6 03/31/21, 15:00
-
TYPO3com voted on patch set 6 V +1 03/31/21, 15:06 Completed build in 05m 39s on Wed, 31 Mar, 03:06 PM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10418
-
core-ci voted on patch set 6 V +1 03/31/21, 15:10 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1942
-
Oliver Klee commented on patch set 6 CR -1 03/31/21, 15:20
ext_tables.php:128UnresolvedInverted switches are really bad for usability. ("Do you want to not enable this feature?") Can we have a non-inverted switch instead? -
Oli Bartsch commented on patch set 6 03/31/21, 19:51
BackendUtility.php:2121UnresolvedPlease also use static:: here.Feature-93845-AllowUserToDisableCSH.rst:3UnresolvedWhile I'm not sure if this is a problem for rendering, it looks not correct. Please use some RST tool like https://forger.typo3.com/utilities/rstFeature-93845-AllowUserToDisableCSH.rst:10UnresolvedThe RST is for a more detailed and less technical description. So please don't just copy the commit message.Feature-93845-AllowUserToDisableCSH.rst:20UnresolvedHow does this affect TSconfig, besides the implicit possibility to override it with `setup.*`? I would also suggest to use EXT:setup since this is the place where the new setting is introduced. -
Andreas Kienast commented on patch set 6 04/01/21, 05:22
Unresolved
What is an "experimented TYPO3 editor"? -
Eric Chavaillaz uploaded patch set 7 04/01/21, 07:54
-
Eric Chavaillaz uploaded patch set 8 04/01/21, 07:55
-
TYPO3com voted on patch set 7 V +1 04/01/21, 08:01 Completed build in 06m 50s on Thu, 1 Apr, 08:01 AM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10424
-
TYPO3com voted on patch set 8 V +1 04/01/21, 08:01 Completed build in 06m 03s on Thu, 1 Apr, 08:01 AM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10425
-
core-ci voted on patch set 7 V +1 04/01/21, 08:07 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1951
-
core-ci voted on patch set 8 V +1 04/01/21, 08:09 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1952
-
Oli Bartsch commented on patch set 8 04/01/21, 08:38
Hi, thought about this again. TBH I don't think we need such option in the user settings. There is no real benefit, since CSH is not interfering the UX. The user has to interact (e.g. click on a columns label) with it on purpose. Actually in v11 we would like to reduce the amount of option in the user settings, instead of introducing new ones. See e.g. #92582, #92560, #92118. However, let's wait for other opinions on that. So I won't block this issue for now.Feature-93845-AllowUserToDisableCSH.rst:26UnresolvedUsually only one EXT is defined. So just EXT:setup would be fine. -
Eric Chavaillaz uploaded patch set 9 04/01/21, 08:40
-
TYPO3com voted on patch set 9 V +1 04/01/21, 08:47 Completed build in 07m 02s on Thu, 1 Apr, 08:47 AM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10428
-
core-ci voted on patch set 9 V +1 04/01/21, 08:50 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1955
-
Oliver Klee wrote 04/01/21, 08:53
Removed reviewer Oliver Klee. -
Eric Chavaillaz commented on patch set 9 04/01/21, 12:06
Reply
I see what you mean. And to be also honest, for me the full CSH feature should be remove. I do not see real benefit of using it. Additionally, this is a non-sense to show an help text when clicking a label. The default behaviour is not respected. When I click on a label, I expect to have the focus on the field (input, textarea, etc.) associated to this label (the "for" attribute). Not to have a help" popup. Finally, it is not accessible, if I work only with the keyboard, the CSH is omited and have no utility. -
Georg Ringer commented on patch set 9 04/01/21, 19:34
I don't like this feature TBH. the goal should be to make the help better and not to have it optional -
Anja Leichsenring commented on patch set 9 04/17/21, 07:14
agreeing with Georg here. This is the wrong approach. If the help is not helpful, we should strive to improve it. -
Richard Haeser commented on patch set 9 04/19/21, 08:11
Totally agree with Oliver, Georg and Anja. We should optimise CSH instead of hiding / removing it IMHO. I can imagine that it should not be bound to a click on the label, but removing the option is not the right way IMHO. -
Christian Kuhn commented on patch set 9 05/27/21, 20:01
Mmmh. I add similar objections to those stated already. It seems this patch won't make it this way and the consensus seems to be that CSH should be improved instead. It is for sure one of the darker parts of the core that did not receive too much overall love for a long time ... I hope it is ok if I go ahead and abandon this approach for now for the sake of a cleaner review system and to at least take some decision. We could try to reach consensus on how to go ahead in this area, maybe in the coredev channel, and create according patches afterwards. I hope this is ok with you for now, Eric. -
Christian Kuhn abandoned the change 05/27/21, 20:01
BackendUtility.php:2121Unresolved