Review main Merged

68665[TASK] Add compatibility with Doctrine DBAL 2.13.0

Benni Mack CR +2 V +2 Normal +30 −30 updated 04/01/21, 14:24

Commit message

This change removes some type hints which are invalid with
Doctrine DBAL 2.13.0 / 3.0 (builds forward compatibility),
and some hard logic to bindValue() functionality
which is PDO-specific and not supported anymore, as a
Result object is returned instead of a Statement object
from DB queries.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Christian Kuhn +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 6

Review log 1020

  1. Benni Mack uploaded patch set 1 04/01/21, 06:59

  2. TYPO3com voted on patch set 1 V -1 04/01/21, 07:05 Completed build in 06m 11s on Thu, 1 Apr, 07:05 AM Test Summary: 8474 of 33503 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10423

  3. core-ci voted on patch set 1 V -1 04/01/21, 07:15 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1950

  4. Benni Mack uploaded patch set 2 04/01/21, 08:00

  5. TYPO3com voted on patch set 2 V -1 04/01/21, 08:16 Completed build in 15m 38s on Thu, 1 Apr, 08:16 AM Test Summary: 7928 of 33503 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10426

  6. core-ci voted on patch set 2 V -1 04/01/21, 08:27 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1953

  7. Benni Mack uploaded patch set 3 04/01/21, 08:31

  8. TYPO3com voted on patch set 3 V +1 04/01/21, 08:38 Completed build in 06m 40s on Thu, 1 Apr, 08:38 AM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10427

  9. core-ci voted on patch set 3 V +1 04/01/21, 08:43 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1954

  10. Benni Mack uploaded patch set 4 04/01/21, 08:59

  11. TYPO3com voted on patch set 4 V +1 04/01/21, 09:08 Completed build in 08m 59s on Thu, 1 Apr, 09:08 AM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10430

  12. core-ci voted on patch set 4 V +1 04/01/21, 09:09 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1957

  13. Benni Mack updated the commit message in patch set 5 04/01/21, 09:47

  14. TYPO3com voted on patch set 5 V +1 04/01/21, 09:53 Completed build in 06m 31s on Thu, 1 Apr, 09:53 AM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10431

  15. core-ci voted on patch set 5 V +1 04/01/21, 10:00 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1958

  16. Christian Kuhn commented on patch set 5 V +1 CR +1 04/01/21, 13:33

    Connection.php:255 Unresolved

    when we raise to 2.13 only in master, this could be an interface - probably BaseResult.
  17. Christian Kuhn commented on patch set 5 04/01/21, 13:33

    nightly is happy with this, too.
  18. Oli Bartsch voted on patch set 5 V +1 CR +1 04/01/21, 14:08

  19. Benni Mack voted on patch set 5 V +2 CR +2 04/01/21, 14:24

  20. Benni Mack merged patch set 6 04/01/21, 14:24