Review main Merged

68666[TASK] Split up RecordList table rendering

Benni Mack CR +2 V +2 Hard +403 −416 updated 04/01/21, 11:42

Commit message

The DatabaseRecordList class has a few larger methods
to compile HTML ready to be rendered.

This change cleans up several parts of DatabaseRecordList
in order to extract further functionality (such as CSV Export)
into an own class:

* Remove unused / overridden styling properties
* Clean up "More records" button at the bottom of the page list
* Rename internal variable $iLimit to $itemsPerPage
* Separate the order of tables to list into a separate method
  "getTablesToRender()" out of the main method "generateList()"
* Explicitly state the $table parameter for "listUrl()"
  methods where applicable
* Move processing of columns-to-render per table to "getColumnsToRender()"
* Move processing of SQL select fields to query to "getFieldsToSelect()"
* Further cleanups regarding types (bool / int)

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Christian Kuhn +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 5

Review log 1018

  1. Benni Mack uploaded patch set 1 04/01/21, 08:56

  2. TYPO3com voted on patch set 1 V +1 04/01/21, 09:07 Completed build in 10m 41s on Thu, 1 Apr, 09:07 AM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10429

  3. core-ci voted on patch set 1 V +1 04/01/21, 09:07 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1956

  4. Oliver Klee commented on patch set 1 04/01/21, 09:12

    RecordListController.php:165

    Simpler: Cast to bool
  5. Christian Kuhn commented on patch set 1 CR -1 04/01/21, 09:55

    will push

    RecordListController.php:165 Reply

    Ack
  6. Christian Kuhn uploaded patch set 2 04/01/21, 10:04

  7. Benni Mack uploaded patch set 3 04/01/21, 10:04

  8. Christian Kuhn uploaded patch set 4 04/01/21, 10:07

  9. Christian Kuhn voted on patch set 4 V +1 CR +1 04/01/21, 10:09

  10. TYPO3com voted on patch set 3 V +1 04/01/21, 10:12 Completed build in 07m 58s on Thu, 1 Apr, 10:12 AM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10433

  11. TYPO3com voted on patch set 2 V +1 04/01/21, 10:12 Completed build in 08m 04s on Thu, 1 Apr, 10:12 AM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10432

  12. TYPO3com voted on patch set 4 V +1 04/01/21, 10:15 Completed build in 07m 15s on Thu, 1 Apr, 10:15 AM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10435

  13. core-ci voted on patch set 2 V +1 04/01/21, 10:16 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1961

  14. core-ci voted on patch set 3 V +1 04/01/21, 10:18 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1962

  15. core-ci voted on patch set 4 V +1 04/01/21, 10:23 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1964

  16. Oli Bartsch voted on patch set 4 V +1 CR +1 04/01/21, 10:27

  17. Benni Mack voted on patch set 4 V +2 CR +2 04/01/21, 11:42

  18. Benni Mack merged patch set 5 04/01/21, 11:42