Review main Merged

68667[TASK] Optimize search box for record lists

Benni Mack CR +2 V +2 Normal +50 −172 updated 04/05/21, 19:51

Commit message

The search box is currently available in
* Page module (docheader)
* List module (docheader)
* Record Selector / Element Browser

All implementations are different but use the same code base:
* The outer wrapper functionality is only needed for the doc header
* The page module is not using the Fluid-based snippet

Additionally, styling is broken due to Bootstrap 5 upgrade.

The change reduces CSS and JS initialization by consolidating
the rendering of the search box and removing the buggy showLimit
functionality since there is no pagination the placeholder is not used.

Ideally, this code would be separated into a separate class
as it is only related to a fragment of DatabaseRecordList.
This is to be handled with a separate patch.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Oli Bartsch +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 15

Review log 1527

Show 12 earlier messages
  1. Benni Mack uploaded patch set 1 04/01/21, 11:41

  2. TYPO3com voted on patch set 1 V +1 04/01/21, 11:49 Completed build in 07m 08s on Thu, 1 Apr, 11:49 AM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10437

  1. core-ci voted on patch set 1 V -1 04/01/21, 11:52 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1966

  2. Benni Mack uploaded patch set 2 04/01/21, 12:18

  3. TYPO3com voted on patch set 2 V +1 04/01/21, 12:24 Completed build in 06m 14s on Thu, 1 Apr, 12:24 PM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10441

  4. core-ci voted on patch set 2 V -1 04/01/21, 12:45 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1971

  5. Benni Mack uploaded patch set 3 04/01/21, 13:10

  6. TYPO3com voted on patch set 3 V +1 04/01/21, 13:18 Completed build in 07m 50s on Thu, 1 Apr, 01:18 PM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10445

  7. core-ci voted on patch set 3 V +1 04/01/21, 13:20 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1975

  8. Christian Kuhn commented on patch set 3 CR -1 04/01/21, 15:08

    working on it.
  9. Christian Kuhn uploaded patch set 4 04/01/21, 15:27

  10. Christian Kuhn commented on patch set 4 04/01/21, 15:28

    Fine with me in general, not very happy with the DatabaseRecordList usage within PageLayoutController, though ... would love to have a better solution "soon" or "now" ;)

    DatabaseRecordList.php:782 Unresolved

    $this->showLimit should be marked as deprecated later - there are some more vars that should vanish, too ... should be done with separate patch in one go.
  11. TYPO3com voted on patch set 4 V +1 04/01/21, 15:34 Completed build in 07m 06s on Thu, 1 Apr, 03:34 PM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10449

  12. core-ci voted on patch set 4 V +1 04/01/21, 15:37 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1980

  13. Guido Schmechel commented on patch set 4 04/02/21, 16:06

    Tested with the current Chrome. When I click in a search box and type something, I now see an X icon twice. Probably not necessarily related to the patch, but we could fix it directly ;-)
  14. Benni Mack uploaded patch set 5 04/02/21, 19:10

  15. Benni Mack commented on patch set 5 04/02/21, 19:12

    Reply

    Please make sure to flush your browser caches, this is one of the drive-by fixes this change solves.
  16. Benni Mack uploaded patch set 6 04/02/21, 19:15

  17. TYPO3com voted on patch set 5 V +1 04/02/21, 19:18 Completed build in 07m 42s on Fri, 2 Apr, 07:18 PM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10468

  18. TYPO3com voted on patch set 6 V +1 04/02/21, 19:22 Completed build in 07m 06s on Fri, 2 Apr, 07:22 PM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10470

  19. core-ci voted on patch set 5 V +1 04/02/21, 19:24 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2002

  20. core-ci voted on patch set 6 V +1 04/02/21, 19:33 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2004

  21. Oli Bartsch voted on patch set 6 V +1 CR +1 04/02/21, 19:56

  22. Daniel Windloff commented on patch set 6 04/04/21, 06:49

    PageLayoutController.php:1049

    I would suggest to not handle the separation of the search box in a separate patch and include it into this one.
  23. Benni Mack commented on patch set 6 04/04/21, 09:01

    PageLayoutController.php:1049 Reply Unresolved

    Thought about this too, but I felt that this change, which already covers a handful smaller bugfixes (1. same HTML code for all three places, 2. remove double clearable/search in input field, 3. remove jumping of the visibility in element browser etc) and this would make it even more complicated to review. I am also don't 100% know yet, how to achieve the separation while keeping the listURL() functionality as this is right now. So this would need more change sets to figure out the best way.
  24. Georg Ringer voted on patch set 6 V +2 CR +2 04/05/21, 19:51

  25. Georg Ringer merged patch set 7 04/05/21, 19:51