68667[TASK] Optimize search box for record lists
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Oli Bartsch +1
-
Verified V +2 Done
- Georg Ringer +2
- Oli Bartsch +1
- TYPO3com +1 CI
- core-ci +1 CI
Issues 1
Files 15
- Build/Sources/Sass/component/_module.scss+0 −8
- Build/Sources/Sass/typo3/structure/_module_web_list.scss+0 −7
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/ToggleSearchToolbox.ts+0 −15
- Build/Sources/TypeScript/recordlist/Resources/Public/TypeScript/BrowseDatabase.ts+0 −5
- Build/Sources/TypeScript/recordlist/Resources/Public/TypeScript/RecordLinkHandler.ts+0 −5
- typo3/sysext/backend/Classes/Controller/PageLayoutController.php2+5 −56
- typo3/sysext/backend/Resources/Public/Css/backend.css+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/ToggleSearchToolbox.js+1 −1
- typo3/sysext/core/Tests/Acceptance/Backend/FormEngine/ElementsGroupCest.php+0 −14
- typo3/sysext/recordlist/Classes/Browser/DatabaseBrowser.php+2 −3
- typo3/sysext/recordlist/Classes/Controller/RecordListController.php+4 −3
- typo3/sysext/recordlist/Classes/RecordList/DatabaseRecordList.php1+8 −14
- typo3/sysext/recordlist/Resources/Private/Templates/Search.html+27 −38
- typo3/sysext/recordlist/Resources/Public/JavaScript/BrowseDatabase.js+1 −1
- typo3/sysext/recordlist/Resources/Public/JavaScript/RecordLinkHandler.js+1 −1
Review log 1527
Show 12 earlier messages
-
Benni Mack uploaded patch set 1 04/01/21, 11:41
-
TYPO3com voted on patch set 1 V +1 04/01/21, 11:49 Completed build in 07m 08s on Thu, 1 Apr, 11:49 AM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10437
-
core-ci voted on patch set 1 V -1 04/01/21, 11:52 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1966
-
Benni Mack uploaded patch set 2 04/01/21, 12:18
-
TYPO3com voted on patch set 2 V +1 04/01/21, 12:24 Completed build in 06m 14s on Thu, 1 Apr, 12:24 PM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10441
-
core-ci voted on patch set 2 V -1 04/01/21, 12:45 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1971
-
Benni Mack uploaded patch set 3 04/01/21, 13:10
-
TYPO3com voted on patch set 3 V +1 04/01/21, 13:18 Completed build in 07m 50s on Thu, 1 Apr, 01:18 PM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10445
-
core-ci voted on patch set 3 V +1 04/01/21, 13:20 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1975
-
Christian Kuhn commented on patch set 3 CR -1 04/01/21, 15:08
working on it. -
Christian Kuhn uploaded patch set 4 04/01/21, 15:27
-
Christian Kuhn commented on patch set 4 04/01/21, 15:28
Fine with me in general, not very happy with the DatabaseRecordList usage within PageLayoutController, though ... would love to have a better solution "soon" or "now" ;)DatabaseRecordList.php:782Unresolved$this->showLimit should be marked as deprecated later - there are some more vars that should vanish, too ... should be done with separate patch in one go. -
TYPO3com voted on patch set 4 V +1 04/01/21, 15:34 Completed build in 07m 06s on Thu, 1 Apr, 03:34 PM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10449
-
core-ci voted on patch set 4 V +1 04/01/21, 15:37 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1980
-
Guido Schmechel commented on patch set 4 04/02/21, 16:06
Tested with the current Chrome. When I click in a search box and type something, I now see an X icon twice. Probably not necessarily related to the patch, but we could fix it directly ;-) -
Benni Mack uploaded patch set 5 04/02/21, 19:10
-
Benni Mack commented on patch set 5 04/02/21, 19:12
Reply
Please make sure to flush your browser caches, this is one of the drive-by fixes this change solves. -
Benni Mack uploaded patch set 6 04/02/21, 19:15
-
TYPO3com voted on patch set 5 V +1 04/02/21, 19:18 Completed build in 07m 42s on Fri, 2 Apr, 07:18 PM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10468
-
TYPO3com voted on patch set 6 V +1 04/02/21, 19:22 Completed build in 07m 06s on Fri, 2 Apr, 07:22 PM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10470
-
core-ci voted on patch set 5 V +1 04/02/21, 19:24 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2002
-
core-ci voted on patch set 6 V +1 04/02/21, 19:33 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2004
-
Oli Bartsch voted on patch set 6 V +1 CR +1 04/02/21, 19:56
-
Daniel Windloff commented on patch set 6 04/04/21, 06:49
PageLayoutController.php:1049I would suggest to not handle the separation of the search box in a separate patch and include it into this one. -
Benni Mack commented on patch set 6 04/04/21, 09:01
PageLayoutController.php:1049Reply UnresolvedThought about this too, but I felt that this change, which already covers a handful smaller bugfixes (1. same HTML code for all three places, 2. remove double clearable/search in input field, 3. remove jumping of the visibility in element browser etc) and this would make it even more complicated to review. I am also don't 100% know yet, how to achieve the separation while keeping the listURL() functionality as this is right now. So this would need more change sets to figure out the best way. -
Georg Ringer voted on patch set 6 V +2 CR +2 04/05/21, 19:51
-
Georg Ringer merged patch set 7 04/05/21, 19:51