Review main Merged

68668[TASK] Clean up TypeScript code for Element Browser / Link Picker

Benni Mack CR +2 V +2 Normal +89 −144 updated 04/02/21, 18:21

Commit message

The Link Picker (RecordLinkHandler) and Element Browser logic
has been simplified to avoid jQuery where possible and to reduce
HTML rendering.

The data-icon information is never evaluated in TypeScript/JavaScript
and can be removed from any kind of HTML rendering, making the
transferred amount of HTML much smaller.

In addition, the insertElement method has been cleaned up to only
use the properties that are evaluated.

As a small side-effect, the InlineControlContainer does not
throw a console.warn if a post message cannot be evaluated
(which is typically the case for non-inline references).

Review

  • Code review CR +2 Done
    • Richard Haeser +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Richard Haeser +2
    • Andreas Kienast +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 16

Review log 713

  1. Benni Mack uploaded patch set 1 04/01/21, 14:24

  2. TYPO3com voted on patch set 1 V -1 04/01/21, 14:24 Completed build in 17s on Thu, 1 Apr, 02:24 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10446

  3. core-ci voted on patch set 1 V -1 04/01/21, 14:25 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1977

  4. Benni Mack uploaded patch set 2 04/01/21, 14:26

  5. TYPO3com voted on patch set 2 V +1 04/01/21, 14:33 Completed build in 06m 40s on Thu, 1 Apr, 02:33 PM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10447

  6. core-ci voted on patch set 2 V +1 04/01/21, 14:37 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1978

  7. Georg Ringer voted on patch set 2 V +1 CR +1 04/01/21, 19:47

  8. Andreas Kienast uploaded patch set 3 04/02/21, 12:29

  9. Andreas Kienast voted on patch set 3 V +1 CR +1 04/02/21, 12:29

  10. TYPO3com voted on patch set 3 V +1 04/02/21, 12:36 Completed build in 06m 30s on Fri, 2 Apr, 12:36 PM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10463

  11. core-ci voted on patch set 3 V +1 04/02/21, 12:40 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1997

  12. Richard Haeser voted on patch set 3 V +2 CR +2 04/02/21, 12:40

  13. Benni Mack merged patch set 4 04/02/21, 18:21