Review main Merged

68669[BUGFIX] Re-add support for existing prepared statements

Benni Mack CR +2 V +2 Easy +27 −14 updated 04/09/21, 19:57

Commit message

The lowlevel bindValue() API is re-introduced in a way that
supports both Doctrine 3.0 and Doctrine 2.10 (for TYPO3 v10)
by checking for the ->getIterator() method on the ForwardCompatibility\Result
object.

For SQLite support, the use of the positional parameters is needed,
as Doctrine DBAL does not support named parameters for manually
wired bound values with SQLite3.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Markus Klein +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Markus Klein +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 2

Files 2

Review log 1016

  1. Benni Mack uploaded patch set 1 04/01/21, 21:33

  2. TYPO3com voted on patch set 1 V -1 04/01/21, 21:44 Completed build in 11m 09s on Thu, 1 Apr, 09:44 PM Test Summary: 2723 of 33503 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10452

  3. core-ci voted on patch set 1 V -1 04/01/21, 21:52 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1983

  4. Christian Kuhn commented on patch set 1 04/02/21, 10:04

    do we need this b/w compat hack for master? wouldn't it be better if we just raise to 2.13 in master?
  5. Benni Mack commented on patch set 1 04/02/21, 10:18

    Reply Unresolved

    I try to have a straight backport and then raise to 2.13 in a separate patch.
  6. Benni Mack uploaded patch set 2 04/02/21, 10:20

  7. TYPO3com voted on patch set 2 V -1 04/02/21, 10:28 Completed build in 07m 29s on Fri, 2 Apr, 10:28 AM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10456

  8. core-ci voted on patch set 2 V -1 04/02/21, 10:31 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1990

  9. Markus Klein commented on patch set 2 04/02/21, 10:34

    BackendUtility.php:18 Unresolved

    This will cause issues if version 2.12 is present
  10. Markus Klein commented on patch set 3 04/02/21, 10:37

    Published edit on patch set 2.
  11. TYPO3com voted on patch set 3 V +1 04/02/21, 10:44 Completed build in 06m 35s on Fri, 2 Apr, 10:44 AM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10457

  12. core-ci voted on patch set 3 V +1 04/02/21, 10:50 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1991

  13. Markus Klein voted on patch set 3 V +1 CR +1 04/02/21, 12:56

  14. Oli Bartsch voted on patch set 3 V +1 CR +1 04/02/21, 19:22

  15. Benni Mack voted on patch set 3 V +2 CR +2 04/09/21, 19:57

  16. Benni Mack merged patch set 4 04/09/21, 19:57