Review main Merged

68671[BUGFIX] Fix change=reload for group fields

Andreas Kienast CR +2 V +2 Easy +27 −11 updated 06/02/21, 07:45

Commit message

This patch implements the "Refresh required" dialog for group fields
configured to request a reload once their value changes.
In the same run the validation is now applied to the field holding the
actual value, which requires a minor change in the validation process.

Review

  • Code review CR +2 Done
    • Richard Haeser +2
    • Anja Leichsenring +1
    • Riny van Tiggelen +1
  • Verified V +2 Done
    • Richard Haeser +2
    • Riny van Tiggelen +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1519

  1. Andreas Kienast uploaded patch set 1 04/02/21, 15:12

  2. TYPO3com voted on patch set 1 V +1 04/02/21, 15:20 Completed build in 07m 17s on Fri, 2 Apr, 03:20 PM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10467

  3. core-ci voted on patch set 1 V +1 04/02/21, 15:24 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2001

  4. Markus Klein voted on patch set 1 CR +1 04/02/21, 21:22

  5. Anja Leichsenring commented on patch set 1 V -1 04/12/21, 16:19

    I tested with styleguide table tx_styleguide_elements_group and field group_requestUpdate_1. While removing a selected entry has the desired effect of asking for reload and then vanishing the modal, this is not the case when adding a new entry. I selected one via the element browser, and the modal appeares. When I confirm the reload, the modal sticks around and won't be removed from view.
  6. Andreas Kienast uploaded patch set 2 05/18/21, 21:26

  7. core-ci voted on patch set 2 V +1 05/18/21, 21:40 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11648

  8. Andreas Kienast rebased onto patch set 3 05/27/21, 19:48

  9. core-ci voted on patch set 3 V +1 05/27/21, 19:58 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11919

  10. Andreas Kienast commented on patch set 3 V -1 05/27/21, 20:43

    There's still a timing issue that hits under unknown circumstances...
  11. Andreas Kienast commented on patch set 3 05/27/21, 21:01

  12. Richard Haeser commented on patch set 3 CR +1 05/28/21, 11:36

    Works fine when the depending patch is installed.
  13. Anja Leichsenring commented on patch set 3 CR +1 05/30/21, 17:29

    after 69305 got merged, this works.
  14. Richard Haeser voted on patch set 3 V +1 05/31/21, 07:58

  15. Andreas Kienast voted on patch set 3 V 0 05/31/21, 08:06

  16. Riny van Tiggelen voted on patch set 3 V +1 CR +1 05/31/21, 19:58

  17. Richard Haeser voted on patch set 3 V +2 CR +2 05/31/21, 19:58

  18. Richard Haeser merged patch set 4 05/31/21, 19:58

  19. Richard Haeser commented on patch set 4 06/02/21, 07:45

    This was broken in v10 as well