68671[BUGFIX] Fix change=reload for group fields
Commit message
Review
-
Code review CR +2 Done
- Richard Haeser +2
- Anja Leichsenring +1
- Riny van Tiggelen +1
-
Verified V +2 Done
- Richard Haeser +2
- Riny van Tiggelen +1
- core-ci +1 CI
Issues 1
Files 3
Review log 1519
-
Andreas Kienast uploaded patch set 1 04/02/21, 15:12
-
TYPO3com voted on patch set 1 V +1 04/02/21, 15:20 Completed build in 07m 17s on Fri, 2 Apr, 03:20 PM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10467
-
core-ci voted on patch set 1 V +1 04/02/21, 15:24 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2001
-
Markus Klein voted on patch set 1 CR +1 04/02/21, 21:22
-
Anja Leichsenring commented on patch set 1 V -1 04/12/21, 16:19
I tested with styleguide table tx_styleguide_elements_group and field group_requestUpdate_1. While removing a selected entry has the desired effect of asking for reload and then vanishing the modal, this is not the case when adding a new entry. I selected one via the element browser, and the modal appeares. When I confirm the reload, the modal sticks around and won't be removed from view. -
Andreas Kienast uploaded patch set 2 05/18/21, 21:26
-
core-ci voted on patch set 2 V +1 05/18/21, 21:40 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11648
-
Andreas Kienast rebased onto patch set 3 05/27/21, 19:48
-
core-ci voted on patch set 3 V +1 05/27/21, 19:58 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11919
-
Andreas Kienast commented on patch set 3 V -1 05/27/21, 20:43
There's still a timing issue that hits under unknown circumstances... -
Andreas Kienast commented on patch set 3 05/27/21, 21:01
-
Richard Haeser commented on patch set 3 CR +1 05/28/21, 11:36
Works fine when the depending patch is installed. -
Anja Leichsenring commented on patch set 3 CR +1 05/30/21, 17:29
after 69305 got merged, this works. -
Richard Haeser voted on patch set 3 V +1 05/31/21, 07:58
-
Andreas Kienast voted on patch set 3 V 0 05/31/21, 08:06
-
Riny van Tiggelen voted on patch set 3 V +1 CR +1 05/31/21, 19:58
-
Richard Haeser voted on patch set 3 V +2 CR +2 05/31/21, 19:58
-
Richard Haeser merged patch set 4 05/31/21, 19:58
-
Richard Haeser commented on patch set 4 06/02/21, 07:45
This was broken in v10 as well