Review main Merged

68692[FEATURE] Resizable navigation for all element / record selectors

Benni Mack CR +2 V +2 Hard +286 −131 updated 04/08/21, 11:59

Commit message

This change adds a new Lit-based custom HTML component
called "<typo3-backend-navigation-switcher>" which moves
the current navigation frame resizable feature in a more flexible
re-usable way.

All RecordLinkHandlers and ElementBrowsers now have a
resizable and collapsible navigation area.

In addition, all logic is now decoupled from Viewport.ts

All ElementBrowser / RecordHandlers now also define
an inline style width to avoid jumping of the navigation area
within the modal box.

Further optimizations in this area:
* Remove the media queries for the CSS classes in the element browser?
* The newly introduced LIT element could be built as shadow DOM

Review

  • Code review CR +2 Done
    • Richard Haeser +2
    • Benjamin Franzke +1
  • Verified V +2 Done
    • Richard Haeser +2
    • Benjamin Franzke +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 26

Show 6 more files

Review log 2241

Show 616 earlier messages
  1. Benni Mack uploaded patch set 1 04/02/21, 22:08

  2. TYPO3com voted on patch set 1 V +1 04/02/21, 22:14 Completed build in 06m 44s on Fri, 2 Apr, 10:14 PM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10473

  3. core-ci voted on patch set 1 V -1 04/02/21, 22:19 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2007

  4. Benni Mack updated the commit message in patch set 2 04/04/21, 20:06

  5. TYPO3com voted on patch set 2 V +1 04/04/21, 20:14 Completed build in 07m 54s on Sun, 4 Apr, 08:14 PM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10478

  6. core-ci voted on patch set 2 V +1 04/04/21, 20:17 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2018

  7. Benni Mack uploaded patch set 3 04/05/21, 11:10

  8. TYPO3com voted on patch set 3 V +1 04/05/21, 11:16 Completed build in 06m 25s on Mon, 5 Apr, 11:16 AM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10479

  9. core-ci voted on patch set 3 V +1 04/05/21, 11:21 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2022

  10. Benni Mack uploaded patch set 4 04/05/21, 21:03

  11. Benni Mack uploaded patch set 5 04/05/21, 21:07

  12. TYPO3com voted on patch set 4 V +1 04/05/21, 21:12 Completed build in 08m 16s on Mon, 5 Apr, 09:12 PM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10482

  13. TYPO3com voted on patch set 5 V +1 04/05/21, 21:14 Completed build in 06m 41s on Mon, 5 Apr, 09:14 PM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10484

  14. core-ci voted on patch set 4 V +1 04/05/21, 21:16 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2029

  15. core-ci voted on patch set 5 V +1 04/05/21, 21:25 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2031

  16. Benni Mack uploaded patch set 6 04/05/21, 21:39

  1. Benni Mack uploaded patch set 7 04/05/21, 21:42

  2. TYPO3com voted on patch set 6 V -1 04/05/21, 21:46 Completed build in 06m 57s on Mon, 5 Apr, 09:46 PM Test Summary: 33266 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10485

  3. core-ci voted on patch set 6 V +1 04/05/21, 21:50 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2032

  4. TYPO3com voted on patch set 7 V -1 04/05/21, 21:50 Completed build in 08m 03s on Mon, 5 Apr, 09:50 PM Test Summary: 32045 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10487

  5. core-ci voted on patch set 7 V +1 04/05/21, 21:59 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2034

  6. Georg Ringer voted on patch set 7 V +1 CR +1 04/06/21, 03:19

  7. TYPO3com voted on patch set 7 V +1 04/06/21, 06:49 Completed build in 9h 15m 04s on Tue, 6 Apr, 06:49 AM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10487

  8. Richard Haeser voted on patch set 7 V +2 CR +2 04/06/21, 08:08

  9. Benjamin Franzke commented on patch set 7 CR -1 04/06/21, 09:24

    ResizableNavigation.ts:103

    Let's have a property (annotated with @internalProperty) that influences the presence of this class within the render() method. Manuellay Removing/adding things via DOM API is best to be avoided and rather reflected as state (attributes or properties). That way we get into purely state-driven element renderings and less jquery-style. I can try to fix that, if it's unclear what I mean, later on.
  10. Richard Haeser voted on patch set 7 V 0 CR 0 04/06/21, 09:42

  11. Benni Mack uploaded patch set 8 04/06/21, 15:31

  12. TYPO3com commented on patch set 8 04/06/21, 15:38 Completed build in 07m 44s on Tue, 6 Apr, 03:38 PM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10495

  13. core-ci commented on patch set 8 04/06/21, 15:46 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2044

  14. Benjamin Franzke uploaded patch set 9 04/07/21, 23:03

  15. Benjamin Franzke commented on patch set 9 04/07/21, 23:03

    ResizableNavigation.ts:103 Reply

    Done
  16. TYPO3com voted on patch set 9 V +1 04/07/21, 23:10 Completed build in 07m 23s on Wed, 7 Apr, 11:10 PM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10534

  17. Benni Mack commented on patch set 9 04/07/21, 23:14

    Any thoughts on the name of the custom element? I thought of: * <typo3-backend-navigation-resizer> * <typo3-backend-navigation-handler> Also for the navigation persistence identifier, I think the trees within the Element Browser / Link Handlers should be unified as well. The common name I found was "browser" (Link Browser / Element Browser / Page Browser / File Browser / Database Browser). So we'll have "browser.navigation.width" or something like that? Or should we go with "selector" in general?

    ResizableNavigation.ts:103 Reply

    thank you!
  18. core-ci voted on patch set 9 V +1 04/07/21, 23:17 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2089

  19. Benjamin Franzke commented on patch set 9 04/08/21, 05:09

    Reply

    I'm fine with typo3-backend-navigation-switcher, I could image for this to be splitted into two separate elements somewhen, but for now this is good. Regarding element browser and to throw in another term: Desktop GUI APIs often use the name "chooser", for example GTK https://developer.gnome.org/gtk3/stable/GtkFileChooser.html I know, it sounds a bit bumpy, but Element Chooser, Page Chooser, File Chooser and Record Chooser (instead of Database Browser) would be very clear terms (IMO).
  20. Benni Mack commented on patch set 9 04/08/21, 06:19

    Reply

    aaah, chooser - great idea! Will keep this in mind for my continued work.
  21. Richard Haeser voted on patch set 9 V +2 CR +2 04/08/21, 07:18

  22. Richard Haeser merged patch set 10 04/08/21, 07:18

  23. Josef Glatz commented on patch set 10 04/08/21, 09:34

    is it or is it not 😉
  24. Benjamin Franzke commented on patch set 10 04/08/21, 11:12

    Reply

    This is a forecast view, that means: It may or may not be done in future ;)
  25. Josef Glatz commented on patch set 10 04/08/21, 11:25

    Reply

    ah I see! thx.