68692[FEATURE] Resizable navigation for all element / record selectors
Commit message
Review
-
Code review CR +2 Done
- Richard Haeser +2
- Benjamin Franzke +1
-
Verified V +2 Done
- Richard Haeser +2
- Benjamin Franzke +1
- TYPO3com +1 CI
- core-ci +1 CI
Issues 1
Files 26
- Build/Sources/Sass/component/_elementbrowser.scss+8 −0
- Build/Sources/Sass/scaffold/_scaffold.scss+4 −1
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/Enum/Viewport/ScaffoldIdentifier.ts+0 −1
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/Viewport/NavigationContainer.ts+2 −30
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/Viewport/ResizableNavigation.ts3new+142 −0
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/Viewport.ts+1 −72
- typo3/sysext/backend/Classes/Controller/BackendController.php+1 −0
- typo3/sysext/backend/Resources/Private/Layouts/ElementBrowser.html+9 −2
- typo3/sysext/backend/Resources/Private/Templates/Backend/Main.html+6 −9
- typo3/sysext/backend/Resources/Public/Css/backend.css+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/Enum/Viewport/ScaffoldIdentifier.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/Viewport/NavigationContainer.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/Viewport/ResizableNavigation.jsnew+23 −0
- typo3/sysext/backend/Resources/Public/JavaScript/Viewport.js+1 −1
- typo3/sysext/core/Documentation/Changelog/master/Feature-93857-ResizableNavigationComponentForAllElementRecordSelectors.rstnew+34 −0
- typo3/sysext/recordlist/Classes/Browser/AbstractElementBrowser.php+1 −0
- typo3/sysext/recordlist/Classes/Browser/DatabaseBrowser.php+1 −0
- typo3/sysext/recordlist/Classes/Browser/FileBrowser.php+1 −0
- typo3/sysext/recordlist/Classes/Browser/FolderBrowser.php+1 −0
- typo3/sysext/recordlist/Classes/LinkHandler/FileLinkHandler.php+4 −1
Show 6 more files
- typo3/sysext/recordlist/Classes/LinkHandler/PageLinkHandler.php+4 −1
- typo3/sysext/recordlist/Classes/LinkHandler/RecordLinkHandler.php+4 −2
- typo3/sysext/recordlist/Resources/Private/Templates/LinkBrowser/File.html+9 −2
- typo3/sysext/recordlist/Resources/Private/Templates/LinkBrowser/Folder.html+9 −2
- typo3/sysext/recordlist/Resources/Private/Templates/LinkBrowser/Page.html+9 −2
- typo3/sysext/recordlist/Resources/Private/Templates/LinkBrowser/Record.html+9 −2
Review log 2241
Show 616 earlier messages
-
Benni Mack uploaded patch set 1 04/02/21, 22:08
-
TYPO3com voted on patch set 1 V +1 04/02/21, 22:14 Completed build in 06m 44s on Fri, 2 Apr, 10:14 PM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10473
-
core-ci voted on patch set 1 V -1 04/02/21, 22:19 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2007
-
Benni Mack updated the commit message in patch set 2 04/04/21, 20:06
-
TYPO3com voted on patch set 2 V +1 04/04/21, 20:14 Completed build in 07m 54s on Sun, 4 Apr, 08:14 PM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10478
-
core-ci voted on patch set 2 V +1 04/04/21, 20:17 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2018
-
Benni Mack uploaded patch set 3 04/05/21, 11:10
-
TYPO3com voted on patch set 3 V +1 04/05/21, 11:16 Completed build in 06m 25s on Mon, 5 Apr, 11:16 AM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10479
-
core-ci voted on patch set 3 V +1 04/05/21, 11:21 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2022
-
Benni Mack uploaded patch set 4 04/05/21, 21:03
-
Benni Mack uploaded patch set 5 04/05/21, 21:07
-
TYPO3com voted on patch set 4 V +1 04/05/21, 21:12 Completed build in 08m 16s on Mon, 5 Apr, 09:12 PM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10482
-
TYPO3com voted on patch set 5 V +1 04/05/21, 21:14 Completed build in 06m 41s on Mon, 5 Apr, 09:14 PM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10484
-
core-ci voted on patch set 4 V +1 04/05/21, 21:16 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2029
-
core-ci voted on patch set 5 V +1 04/05/21, 21:25 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2031
-
Benni Mack uploaded patch set 6 04/05/21, 21:39
-
Benni Mack uploaded patch set 7 04/05/21, 21:42
-
TYPO3com voted on patch set 6 V -1 04/05/21, 21:46 Completed build in 06m 57s on Mon, 5 Apr, 09:46 PM Test Summary: 33266 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10485
-
core-ci voted on patch set 6 V +1 04/05/21, 21:50 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2032
-
TYPO3com voted on patch set 7 V -1 04/05/21, 21:50 Completed build in 08m 03s on Mon, 5 Apr, 09:50 PM Test Summary: 32045 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10487
-
core-ci voted on patch set 7 V +1 04/05/21, 21:59 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2034
-
Georg Ringer voted on patch set 7 V +1 CR +1 04/06/21, 03:19
-
TYPO3com voted on patch set 7 V +1 04/06/21, 06:49 Completed build in 9h 15m 04s on Tue, 6 Apr, 06:49 AM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10487
-
Richard Haeser voted on patch set 7 V +2 CR +2 04/06/21, 08:08
-
Benjamin Franzke commented on patch set 7 CR -1 04/06/21, 09:24
-
Richard Haeser voted on patch set 7 V 0 CR 0 04/06/21, 09:42
-
Benni Mack uploaded patch set 8 04/06/21, 15:31
-
TYPO3com commented on patch set 8 04/06/21, 15:38 Completed build in 07m 44s on Tue, 6 Apr, 03:38 PM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10495
-
core-ci commented on patch set 8 04/06/21, 15:46 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2044
-
Benjamin Franzke uploaded patch set 9 04/07/21, 23:03
-
Benjamin Franzke commented on patch set 9 04/07/21, 23:03
ResizableNavigation.ts:103ReplyDone -
TYPO3com voted on patch set 9 V +1 04/07/21, 23:10 Completed build in 07m 23s on Wed, 7 Apr, 11:10 PM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10534
-
Benni Mack commented on patch set 9 04/07/21, 23:14
Any thoughts on the name of the custom element? I thought of: * <typo3-backend-navigation-resizer> * <typo3-backend-navigation-handler> Also for the navigation persistence identifier, I think the trees within the Element Browser / Link Handlers should be unified as well. The common name I found was "browser" (Link Browser / Element Browser / Page Browser / File Browser / Database Browser). So we'll have "browser.navigation.width" or something like that? Or should we go with "selector" in general?ResizableNavigation.ts:103Replythank you! -
core-ci voted on patch set 9 V +1 04/07/21, 23:17 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2089
-
Benjamin Franzke commented on patch set 9 04/08/21, 05:09
Reply
I'm fine with typo3-backend-navigation-switcher, I could image for this to be splitted into two separate elements somewhen, but for now this is good. Regarding element browser and to throw in another term: Desktop GUI APIs often use the name "chooser", for example GTK https://developer.gnome.org/gtk3/stable/GtkFileChooser.html I know, it sounds a bit bumpy, but Element Chooser, Page Chooser, File Chooser and Record Chooser (instead of Database Browser) would be very clear terms (IMO). -
Benni Mack commented on patch set 9 04/08/21, 06:19
Reply
aaah, chooser - great idea! Will keep this in mind for my continued work. -
Richard Haeser voted on patch set 9 V +2 CR +2 04/08/21, 07:18
-
Richard Haeser merged patch set 10 04/08/21, 07:18
-
Josef Glatz commented on patch set 10 04/08/21, 09:34
is it or is it not 😉 -
Benjamin Franzke commented on patch set 10 04/08/21, 11:12
Reply
This is a forecast view, that means: It may or may not be done in future ;) -
Josef Glatz commented on patch set 10 04/08/21, 11:25
Reply
ah I see! thx.
ResizableNavigation.ts:103