Review main Merged

68712[TASK] Move doc header generation out of DatabaseRecordList

Benni Mack CR +2 V +2 Hard +366 −378 updated 04/07/21, 09:11

Commit message

This change primarily moves the ModuleTemplate / DocHeader
generation out of the DatabaseRecordList class into the actual
controller where ModuleTemplate is used.

The main controller method is also split up in smaller chunks
(such as Clipboard initialization).

In addition, several methods and properties are marked
as protected if they are only used internally within DatabaseRecordList.

Further steps in this area are to separate code from DatabaseRecordList
which is not bound to the record listing.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 2

Review log 715

  1. Benni Mack uploaded patch set 1 04/06/21, 12:58

  2. TYPO3com voted on patch set 1 V -1 04/06/21, 13:03 Completed build in 05m 08s on Tue, 6 Apr, 01:03 PM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10490

  3. Benni Mack uploaded patch set 2 04/06/21, 13:08

  4. core-ci voted on patch set 1 V -1 04/06/21, 13:08 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2040

  5. TYPO3com voted on patch set 2 V -1 04/06/21, 13:14 Completed build in 06m 13s on Tue, 6 Apr, 01:14 PM Test Summary: 33265 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10491

  6. core-ci voted on patch set 2 V -1 04/06/21, 13:18 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2041

  7. Benni Mack uploaded patch set 3 04/06/21, 13:25

  8. TYPO3com voted on patch set 3 V +1 04/06/21, 13:32 Completed build in 07m 09s on Tue, 6 Apr, 01:32 PM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10492

  9. core-ci voted on patch set 3 V +1 04/06/21, 13:36 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2042

  10. Benni Mack uploaded patch set 4 04/06/21, 18:58

  11. TYPO3com voted on patch set 4 V +1 04/06/21, 19:05 Completed build in 07m 23s on Tue, 6 Apr, 07:05 PM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10508

  12. core-ci voted on patch set 4 V +1 04/06/21, 19:08 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2058

  13. Oli Bartsch voted on patch set 4 V +1 CR +1 04/07/21, 08:22

  14. Christian Kuhn voted on patch set 4 V +2 CR +2 04/07/21, 09:11

  15. Christian Kuhn merged patch set 5 04/07/21, 09:11