Review main Abandoned

68713[POC][FEATURE] Update Backend URLs when navigating - test

Benni Mack CR 0 V 0 Normal +80 −11 updated 04/13/21, 08:34

Commit message

Wouldn't it be cool if editors could share their current URL just by clicking in the browser?

This patch adds a iframe listener so every time a module gets changed, the URL in the browser
is updated.

To Be Done:
+ push state should remove the token query parameter
+ pushState also should work for non-modules / regular routes
- Resolve URLs handled in push state
- Resolve URLs when using the browser back button
- evaluate the query parameter (re-auth) when the link is used in another browser
- Adding tests when a user visits a non-authenticated URL, authenticate (and show error or redirect etc)
- Fix popups (in EditDocumentController)
- Test Install Tool

Review

  • Code review CR 0
  • Verified V 0

Files 7

Review log 24

  1. Benni Mack uploaded patch set 1 04/06/21, 17:29

  2. TYPO3com voted on patch set 1 V -1 04/06/21, 17:29 Completed build in 28s on Tue, 6 Apr, 05:29 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10506

  3. core-ci voted on patch set 1 V -1 04/06/21, 17:30 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2056

  4. Benni Mack abandoned the change 04/13/21, 08:34