Review main Merged

68714[TASK] Only persist on POST requests in EditDocumentController

Benni Mack CR +2 V +2 Normal +38 −34 updated 10/13/21, 12:42

Commit message

This change ensures that writing to EditDocumentController
only happens for POST requests, as EditDocumentController
currently takes care of rendering the form AND saving
a record via DataHandler.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1625

  1. Benni Mack uploaded patch set 1 04/06/21, 19:52

  2. TYPO3com voted on patch set 1 V -1 04/06/21, 19:58 Completed build in 06m 37s on Tue, 6 Apr, 07:58 PM Test Summary: 6 of 33503 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10511

  3. core-ci voted on patch set 1 V -1 04/06/21, 20:05 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2060

  4. Benni Mack rebased onto patch set 2 05/01/21, 12:16

  5. core-ci voted on patch set 2 V -1 05/01/21, 12:33 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11008

  6. Benni Mack rebased onto patch set 3 05/10/21, 10:05

  7. core-ci voted on patch set 3 V -1 05/10/21, 10:19 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11332

  8. Benni Mack uploaded patch set 4 05/11/21, 18:47

  9. Benni Mack uploaded patch set 5 05/11/21, 18:48

  10. core-ci voted on patch set 4 V +1 05/11/21, 19:01 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11390

  11. Benni Mack updated the commit message in patch set 6 05/11/21, 20:45

  12. core-ci voted on patch set 6 V +1 05/11/21, 20:56 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11411

  13. core-ci voted on patch set 5 V +1 05/11/21, 21:04 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11391

  14. Benjamin Franzke commented on patch set 6 05/11/21, 21:07

    EditDocumentController.php:400

    Hm, should we add an additional METHOD check here? I mean per PSR-7 getParsedBody is not limited to only return results for method POST and our implementation would allow results for PUT, PATCH, POST and DELETE queries.
  15. Oli Bartsch uploaded patch set 7 05/11/21, 21:33

  16. Oli Bartsch uploaded patch set 8 05/11/21, 21:42

  17. core-ci voted on patch set 7 V +1 05/11/21, 21:45 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11414

  18. Oli Bartsch commented on patch set 8 05/11/21, 21:49

    EditDocumentController.php:400 Reply

    Done
  19. Oli Bartsch voted on patch set 8 V +1 CR +1 05/11/21, 21:51

  20. core-ci voted on patch set 8 V +1 05/11/21, 21:55 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11415

  21. Benjamin Franzke voted on patch set 8 V +2 CR +2 05/12/21, 04:02

  22. Benjamin Franzke merged patch set 9 05/12/21, 04:02

  23. Oliver Hader commented on patch set 9 09/06/21, 20:06

    EditDocumentController.php:416

    FYI: Redirect instead of HTML response caused issue #95123
  24. Benjamin Franzke commented on patch set 9 10/01/21, 19:14

    EditDocumentController.php:416 Reply

  25. Benni Mack commented on patch set 9 10/13/21, 12:42

    EditDocumentController.php:416 Reply

    Thanks!