Review main Merged

68716[BUGFIX] Use correct field name ses_permanent in UserSessionManager

Georg Ringer CR +2 V +2 Easy +2 −2 updated 04/07/21, 06:33

Commit message

The correct field name is `ses_permanent` instead of `is_permanent`.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Markus Klein +1
    • Xavier Perseguers +1
  • Verified V +2 Done
    • Benni Mack +2
    • Xavier Perseguers +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 1

Review log 68

  1. Georg Ringer uploaded patch set 1 04/06/21, 20:09

  2. Georg Ringer commented on patch set 1 04/06/21, 20:10

    This change is ready for review.
  3. TYPO3com voted on patch set 1 V +1 04/06/21, 20:18 Completed build in 08m 35s on Tue, 6 Apr, 08:18 PM Test Summary: 33265 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10513

  4. core-ci voted on patch set 1 V +1 04/06/21, 20:20 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2062

  5. Xavier Perseguers commented on patch set 1 V +1 CR +1 04/06/21, 20:22

    thanks
  6. Markus Klein commented on patch set 1 CR +1 04/06/21, 20:55

    I guess we need better test-coverage
  7. Benni Mack voted on patch set 1 V +2 CR +2 04/07/21, 06:33

  8. Benni Mack merged patch set 2 04/07/21, 06:33