Review main Merged

68717[BUGFIX] Ensure password recovery email can be fully translated

Xavier Perseguers CR +2 V +2 Easy +4 −1 updated 04/19/21, 18:41

Commit message

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Josef Glatz +1
    • Oli Bartsch +1
    • Markus Klein +1
    • Guido Schmechel +1
  • Verified V +2 Done
    • Benni Mack +2
    • Josef Glatz +1
    • Oli Bartsch +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 2

Review log 1014

  1. Xavier Perseguers uploaded patch set 1 04/06/21, 21:03

  2. TYPO3com voted on patch set 1 V +1 04/06/21, 21:11 Completed build in 07m 36s on Tue, 6 Apr, 09:11 PM Test Summary: 33266 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10515

  3. core-ci voted on patch set 1 V +1 04/06/21, 21:14 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2064

  4. Xavier Perseguers commented on patch set 1 V -1 04/07/21, 08:54

    Damn, this doesn't work like that because the rendering context is not bound to EXT:felogin
  5. Xavier Perseguers uploaded patch set 2 04/07/21, 08:58

  6. TYPO3com voted on patch set 2 V +1 04/07/21, 09:06 Completed build in 07m 43s on Wed, 7 Apr, 09:06 AM Test Summary: 33265 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10519

  7. core-ci voted on patch set 2 V +1 04/07/21, 09:09 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2071

  8. Markus Klein voted on patch set 2 CR +1 04/07/21, 09:17

  9. Benni Mack voted on patch set 2 CR +2 04/07/21, 19:33

  10. Josef Glatz voted on patch set 2 V +1 CR +1 04/08/21, 06:40

  11. Oli Bartsch voted on patch set 2 V +1 CR +1 04/08/21, 09:11

  12. Guido Schmechel voted on patch set 2 CR +1 04/08/21, 20:24

  13. Benni Mack voted on patch set 2 V +2 04/19/21, 18:41

  14. Benni Mack merged patch set 3 04/19/21, 18:41