Review main Merged

68721[BUGFIX] Return expected value on GU::writeFileToTypo3tempDir success

Riny van Tiggelen CR +2 V +2 Easy +6 −5 updated 04/29/21, 09:44

Commit message

When TYPO3 is in composer mode (var is outside public path),
GeneralUtility::writeFileToTypo3tempDir now returns NULL for
successful operation as stated in the docblock.

Review

  • Code review CR +2 Done
    • Riny van Tiggelen +2
    • Richard Haeser +1
    • Christian Kuhn +1
    • Benni Mack +1
  • Verified V +2 Done
    • Riny van Tiggelen +2
    • Richard Haeser +1
    • Christian Kuhn +1
    • Benni Mack +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 2

Review log 913

  1. Riny van Tiggelen uploaded patch set 1 04/07/21, 11:31

  2. TYPO3com voted on patch set 1 V +1 04/07/21, 11:37 Completed build in 05m 55s on Wed, 7 Apr, 11:37 AM Test Summary: 33269 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10522

  3. core-ci voted on patch set 1 V +1 04/07/21, 11:45 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2074

  4. Marieke de Bruin commented on patch set 1 V +1 CR +1 04/07/21, 13:19

    Unresolved

    Tested in CMS10
  5. Riny van Tiggelen updated the commit message in patch set 2 04/23/21, 08:16

  6. TYPO3com voted on patch set 2 V +1 04/23/21, 08:22 Completed build in 05m 53s on Fri, 23 Apr, 08:22 AM Test Summary: 33308 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10821

  7. core-ci voted on patch set 2 V +1 04/23/21, 08:28 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10626

  8. Richard Haeser voted on patch set 2 V +1 CR +1 04/23/21, 09:49

  9. Benni Mack voted on patch set 2 V +1 CR +1 04/23/21, 20:01

  10. Richard Haeser commented on patch set 2 04/26/21, 19:18

    Riny, this patch is good to go. Do you want to merge this patch as a first try?
  11. Christian Kuhn voted on patch set 2 V +1 CR +1 04/27/21, 19:35

  12. Riny van Tiggelen voted on patch set 2 V +2 CR +2 04/29/21, 09:44

  13. Riny van Tiggelen merged patch set 3 04/29/21, 09:44