Review main Merged

68722[BUGFIX] Send change event to proper slug input field

Oliver Hader CR +2 V +2 Easy +3 −2 updated 04/07/21, 19:09

Commit message

When regenerating a slug value via form engine in the backend user
interface, changed states are not addressed anymore. Corresponding
JavaScript `change` event has to be triggered for the element that
is used to trigger changes for form engine validation.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Xavier Perseguers +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Xavier Perseguers +1
    • Benni Mack +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 2

Review log 57

  1. Oliver Hader uploaded patch set 1 04/07/21, 16:13

  2. Xavier Perseguers commented on patch set 1 V +1 CR +1 04/07/21, 16:16

    Many thanks!
  3. TYPO3com voted on patch set 1 V +1 04/07/21, 16:19 Completed build in 06m 47s on Wed, 7 Apr, 04:19 PM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10526

  4. core-ci voted on patch set 1 V +1 04/07/21, 16:24 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2078

  5. Benni Mack voted on patch set 1 V +1 CR +1 04/07/21, 18:39

  6. Oliver Hader voted on patch set 1 V +2 CR +2 04/07/21, 19:09

  7. Oliver Hader merged patch set 2 04/07/21, 19:09