Review main Abandoned

68723[TASK] Use named export for BroadcastService module

Oliver Hader CR 0 V 0 Normal +32 −27 updated 04/08/21, 12:31

Commit message

As a side effect this allows to use `BroadcastService` for different
channel topics as well - not just for hard-coded `typo3`.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 10

Review log 1016

  1. Oliver Hader uploaded patch set 1 04/08/21, 08:54

  2. Oliver Hader voted on patch set 1 V -1 04/08/21, 08:57

  3. TYPO3com voted on patch set 1 V +1 04/08/21, 09:01 Completed build in 07m 06s on Thu, 8 Apr, 09:01 AM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10535

  4. Oliver Hader commented on patch set 1 04/08/21, 09:02

    LOL
  5. Oliver Hader uploaded patch set 2 04/08/21, 09:07

  6. core-ci voted on patch set 1 V -1 04/08/21, 09:15 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2093

  7. TYPO3com voted on patch set 2 V +1 04/08/21, 09:15 Completed build in 07m 29s on Thu, 8 Apr, 09:15 AM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10537

  8. core-ci voted on patch set 2 V +1 04/08/21, 09:26 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2097

  9. Oliver Hader voted on patch set 2 CR -1 04/08/21, 10:32

  10. Oliver Hader marked it work in progress 04/08/21, 10:36

  11. Oliver Hader uploaded patch set 3 04/08/21, 11:12

  12. Oliver Hader commented on patch set 3 04/08/21, 11:13

    This change is ready for review.
  13. TYPO3com voted on patch set 3 V +1 04/08/21, 11:19 Completed build in 07m 18s on Thu, 8 Apr, 11:19 AM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10545

  14. core-ci voted on patch set 3 V +1 04/08/21, 11:23 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2105

  15. Benni Mack voted on patch set 3 V +1 CR +1 04/08/21, 11:26

  16. Oliver Hader abandoned the change 04/08/21, 12:31

    Stupid idea...