Review 10.4 Abandoned

68724[TASK] Use named export for BroadcastService module

Oliver Hader CR 0 V 0 Normal +32 −27 updated 04/08/21, 12:32

Commit message

As a side effect this allows to use `BroadcastService` for different
channel topics as well - not just for hard-coded `typo3`.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 10

Review log 814

  1. Oliver Hader uploaded patch set 1 04/08/21, 08:54

  2. Oliver Hader commented on patch set 1 CR -1 04/08/21, 08:55

    Waiting for master...
  3. TYPO3com voted on patch set 1 V +1 04/08/21, 09:05 Completed build in 10m 22s on Thu, 8 Apr, 09:05 AM Test Summary: 75948 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1299

  4. Oliver Hader uploaded patch set 2 04/08/21, 09:07

  5. core-ci voted on patch set 1 V -1 04/08/21, 09:15 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2094

  6. TYPO3com voted on patch set 2 V +1 04/08/21, 09:19 Completed build in 11m 17s on Thu, 8 Apr, 09:19 AM Test Summary: 75948 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1300

  7. core-ci voted on patch set 2 V +1 04/08/21, 09:23 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2096

  8. Oliver Hader voted on patch set 2 CR -1 04/08/21, 10:32

  9. Oliver Hader commented on patch set 2 04/08/21, 11:13

    `master` changes need to be added
  10. Oliver Hader commented on patch set 2 04/08/21, 11:14

  11. Oliver Hader uploaded patch set 3 04/08/21, 11:54

  12. TYPO3com voted on patch set 3 V +1 04/08/21, 12:03 Completed build in 08m 50s on Thu, 8 Apr, 12:03 PM Test Summary: 75948 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1301

  13. core-ci voted on patch set 3 V +1 04/08/21, 12:14 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2110

  14. Oliver Hader abandoned the change 04/08/21, 12:32

    Stupid idea...