Review main Merged

68726[BUGFIX] Prevent saveAndClose in MultiStep wizard

Oli Bartsch CR +2 V +2 Easy +2 −2 updated 04/16/21, 12:28

Commit message

With #90461 a new option "saveAndClose" was added
to the newContentElement wizard. When opening the
wizard and selecting a content type with such option set,
the new element will directly be created - no FormEngine
interaction - and placed at the position (colPos, sorting),
the user opened the wizard.

This functionality however does not work when the wizard
was opened without such page context, for example via the
"new record view" in the recordlist. The position must then
be defined by the user explicitly in the MultiStep wizard, so
no "saveAndClose" functionality is available in such cases.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Jochen Roth +1
  • Verified V +2 Done
    • Benni Mack +2
    • Jochen Roth +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 1

Review log 46

  1. Oli Bartsch uploaded patch set 1 04/08/21, 09:08

  2. TYPO3com voted on patch set 1 V +1 04/08/21, 09:16 Completed build in 07m 38s on Thu, 8 Apr, 09:16 AM Test Summary: 33265 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10538

  3. core-ci voted on patch set 1 V +1 04/08/21, 09:29 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2098

  4. Jochen Roth voted on patch set 1 V +1 CR +1 04/16/21, 07:57

  5. Benni Mack voted on patch set 1 V +2 CR +2 04/16/21, 12:28

  6. Benni Mack merged patch set 2 04/16/21, 12:28