Review main Merged

68727[BUGFIX] Reload page module after deleting content

Oli Bartsch CR +2 V +2 Easy +3 −1 updated 04/16/21, 12:29

Commit message

The page module is now being reloaded when
deleting a content element via the context menu.

Side note: Since there are a lot of functionalities
in the module, e.g. translation, it isn't sufficient to
just remove the element from DOM, like it's done in
recordlist.
The whole module needs to be reloaded / reinitialized.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Jochen Roth +1
  • Verified V +2 Done
    • Benni Mack +2
    • Jochen Roth +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 2

Review log 57

  1. Oli Bartsch uploaded patch set 1 04/08/21, 10:41

  2. TYPO3com voted on patch set 1 V +1 04/08/21, 10:48 Completed build in 06m 23s on Thu, 8 Apr, 10:48 AM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10544

  3. core-ci voted on patch set 1 V +1 04/08/21, 10:51 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2104

  4. Benni Mack commented on patch set 1 V +1 CR +1 04/08/21, 12:20

    dirty, but it works
  5. Jochen Roth voted on patch set 1 V +1 CR +1 04/13/21, 10:11

  6. Benni Mack voted on patch set 1 V +2 CR +2 04/16/21, 12:29

  7. Benni Mack merged patch set 2 04/16/21, 12:29