Review main Abandoned

68728[WIP][FEATURE] Introduce client history management

Oliver Hader CR 0 V 0 Normal +126 −0 updated 04/08/21, 12:31

Commit message

Navigation events in (currently still existing) iframes are broadcasted
to corresponding top application of the backend user interface. History
(and later routing) hast to be handled at that top application scope.

@todo
* proper browser history API invocation
  + define proper state (frame/component, identifier/page-id, payload)
  + prepare for later interaction with routing, define serialized state
* (maybe) make use of `<title>` tags in iframes, which would be shown
  in the browser history as well - currently it's just the site title
  and TYPO3 version, e.g. "TYPO3 v11 [TYPO3 CMS 11.2.0-dev]"

Review

  • Code review CR 0
  • Verified V 0

Files 5

Review log 48

  1. Oliver Hader uploaded patch set 1 04/08/21, 11:12

  2. TYPO3com voted on patch set 1 V -1 04/08/21, 11:12 Completed build in 16s on Thu, 8 Apr, 11:12 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10546

  3. Oliver Hader commented on patch set 1 04/08/21, 11:19

    PageRenderer.php:1358 Unresolved

    Should be moved to iframe/module dispatchers... anything that renders HTML for a direct(!) subframe - exclude element-browser modals etc.
  4. core-ci voted on patch set 1 V +1 04/08/21, 11:25 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2106

  5. Oliver Hader uploaded patch set 2 04/08/21, 12:17

  6. TYPO3com voted on patch set 2 V -1 04/08/21, 12:25 Completed build in 07m 24s on Thu, 8 Apr, 12:25 PM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10554

  7. core-ci voted on patch set 2 V +1 04/08/21, 12:28 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2115

  8. Oliver Hader abandoned the change 04/08/21, 12:31

    Stupid idea...