68729[TASK] Set ModuleTemplate details from request
Commit message
Review
-
Code review CR +2 Done
- Oliver Hader +2
- Oli Bartsch +1
-
Verified V +2 Done
- Oliver Hader +2
- Oli Bartsch +1
- TYPO3com +1 CI
- core-ci +1 CI
Issues 1
Files 70
- typo3/sysext/backend/Classes/Controller/ContentElement/ElementHistoryController.php+19 −8
- typo3/sysext/backend/Classes/Controller/ContentElement/ElementInformationController.php+19 −20
- typo3/sysext/backend/Classes/Controller/ContentElement/MoveElementController.php+20 −6
- typo3/sysext/backend/Classes/Controller/ContentElement/NewContentElementController.php+23 −19
- typo3/sysext/backend/Classes/Controller/Page/NewMultiplePagesController.php+9 −9
- typo3/sysext/backend/Classes/Controller/Page/SortSubPagesController.php+9 −9
- typo3/sysext/backend/Classes/Controller/Wizard/TableController.php+22 −11
- typo3/sysext/backend/Classes/Controller/AboutController.php+30 −26
- typo3/sysext/backend/Classes/Controller/AbstractMfaController.php+6 −4
- typo3/sysext/backend/Classes/Controller/BackendController.php+25 −42
- typo3/sysext/backend/Classes/Controller/DummyController.php+11 −4
- typo3/sysext/backend/Classes/Controller/EditDocumentController.php+33 −49
- typo3/sysext/backend/Classes/Controller/FileSystemNavigationFrameController.php+26 −14
- typo3/sysext/backend/Classes/Controller/HelpController.php+22 −23
- typo3/sysext/backend/Classes/Controller/LinkBrowserController.php3+2 −6
- typo3/sysext/backend/Classes/Controller/LoginController.php+22 −37
- typo3/sysext/backend/Classes/Controller/MfaConfigurationController.php+21 −4
- typo3/sysext/backend/Classes/Controller/MfaController.php+1 −0
- typo3/sysext/backend/Classes/Controller/NewRecordController.php+36 −29
- typo3/sysext/backend/Classes/Controller/PageLayoutController.php+26 −25
Show 50 more files
- typo3/sysext/backend/Classes/Controller/SiteConfigurationController.php+30 −25
- typo3/sysext/backend/Classes/Template/ModuleTemplate.php3+36 −38
- typo3/sysext/backend/Classes/Template/ModuleTemplateFactory.phpnew+53 −0
- typo3/sysext/backend/Configuration/Services.yaml+47 −0
- typo3/sysext/backend/Tests/Functional/Controller/EditDocumentControllerTest.php+2 −3
- typo3/sysext/backend/Tests/Functional/Controller/MfaConfigurationControllerTest.php+5 −3
- typo3/sysext/backend/Tests/Functional/Controller/MfaControllerTest.php+3 −3
- typo3/sysext/backend/Tests/Unit/Controller/EditDocumentControllerTest.php+14 −6
- typo3/sysext/dashboard/Classes/Controller/DashboardController.php+34 −55
- typo3/sysext/filelist/Classes/Controller/File/CreateFolderController.php+25 −13
- typo3/sysext/filelist/Classes/Controller/File/EditFileController.php+21 −16
- typo3/sysext/filelist/Classes/Controller/File/FileUploadController.php+29 −11
- typo3/sysext/filelist/Classes/Controller/File/RenameFileController.php+31 −10
- typo3/sysext/filelist/Classes/Controller/File/ReplaceFileController.php+31 −10
- typo3/sysext/filelist/Configuration/Services.yaml+15 −0
- typo3/sysext/impexp/Classes/Controller/ExportController.php+14 −8
- typo3/sysext/impexp/Classes/Controller/ImportController.php+4 −5
- typo3/sysext/impexp/Classes/Controller/ImportExportController.php+19 −13
- typo3/sysext/impexp/Configuration/Services.yaml+6 −0
- typo3/sysext/info/Classes/Controller/InfoModuleController.php+21 −23
- typo3/sysext/linkvalidator/Classes/Report/LinkValidatorReport.php+21 −7
- typo3/sysext/lowlevel/Classes/Controller/ConfigurationController.php+17 −7
- typo3/sysext/lowlevel/Classes/Controller/DatabaseIntegrityController.php+23 −22
- typo3/sysext/lowlevel/Classes/ServiceProvider.php+25 −1
- typo3/sysext/recordlist/Classes/Browser/AbstractElementBrowser.php+40 −29
- typo3/sysext/recordlist/Classes/Browser/DatabaseBrowser.php+1 −1
- typo3/sysext/recordlist/Classes/Browser/FileBrowser.php+3 −19
- typo3/sysext/recordlist/Classes/Browser/FolderBrowser.php+1 −1
- typo3/sysext/recordlist/Classes/Browser/RecordBrowser.php+1 −4
- typo3/sysext/recordlist/Classes/Controller/AbstractLinkBrowserController.php+32 −14
- typo3/sysext/recordlist/Classes/Controller/ElementBrowserController.php+3 −18
- typo3/sysext/recordlist/Classes/Controller/RecordListController.php+28 −31
- typo3/sysext/recordlist/Configuration/Services.yaml+22 −1
- typo3/sysext/recycler/Classes/Controller/RecyclerModuleController.php+21 −4
- typo3/sysext/recycler/Configuration/Services.yaml+3 −0
- typo3/sysext/redirects/Classes/Controller/ManagementController.php+15 −15
- typo3/sysext/reports/Classes/Controller/ReportController.php+15 −13
- typo3/sysext/reports/Configuration/Services.yaml+3 −0
- typo3/sysext/rte_ckeditor/Classes/Controller/BrowseLinksController.php+2 −6
- typo3/sysext/rte_ckeditor/Configuration/Services.yaml+5 −0
- typo3/sysext/scheduler/Classes/Controller/SchedulerModuleController.php+37 −49
- typo3/sysext/scheduler/Configuration/Services.yaml+3 −0
- typo3/sysext/setup/Classes/Controller/SetupModuleController.php+33 −31
- typo3/sysext/tstemplate/Classes/Controller/TypoScriptTemplateModuleController.php+29 −39
- typo3/sysext/tstemplate/Configuration/Services.yaml+3 −0
- typo3/sysext/viewpage/Classes/Controller/ViewModuleController.php+41 −27
- typo3/sysext/viewpage/Configuration/Services.yaml+3 −0
- typo3/sysext/workspaces/Classes/Controller/PreviewController.php+40 −37
- typo3/sysext/workspaces/Classes/Controller/ReviewController.php+36 −43
- typo3/sysext/workspaces/Configuration/Services.yaml+6 −0
Review log 2350
Show 1125 earlier messages
-
Benni Mack uploaded patch set 1 04/08/21, 12:18
-
TYPO3com voted on patch set 1 V +1 04/08/21, 12:25 Completed build in 07m 25s on Thu, 8 Apr, 12:25 PM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10555
-
core-ci voted on patch set 1 V +1 04/08/21, 12:30 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2116
-
Benni Mack uploaded patch set 2 04/08/21, 19:19
-
TYPO3com voted on patch set 2 V -1 04/08/21, 19:26 Completed build in 06m 45s on Thu, 8 Apr, 07:26 PM Test Summary: 549 of 33503 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10557
-
core-ci voted on patch set 2 V -1 04/08/21, 19:33 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2118
-
Benni Mack uploaded patch set 3 04/08/21, 20:39
-
TYPO3com voted on patch set 3 V -1 04/08/21, 20:45 Completed build in 06m 20s on Thu, 8 Apr, 08:45 PM Test Summary: 848 of 33503 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10559
-
core-ci voted on patch set 3 V -1 04/08/21, 20:53 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2120
-
Benni Mack uploaded patch set 4 04/08/21, 21:05
-
TYPO3com voted on patch set 4 V -1 04/08/21, 21:13 Completed build in 07m 53s on Thu, 8 Apr, 09:13 PM Test Summary: 105 of 33503 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10560
-
Benni Mack uploaded patch set 5 04/08/21, 21:19
-
core-ci voted on patch set 4 V -1 04/08/21, 21:19 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2121
-
TYPO3com voted on patch set 5 V -1 04/08/21, 21:27 Completed build in 08m 20s on Thu, 8 Apr, 09:27 PM Test Summary: 99 of 33503 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10561
-
core-ci voted on patch set 5 V -1 04/08/21, 21:33 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2122
-
Benni Mack rebased onto patch set 6 04/08/21, 22:37
-
TYPO3com voted on patch set 6 V -1 04/08/21, 22:43 Completed build in 05m 53s on Thu, 8 Apr, 10:43 PM Test Summary: 99 of 33503 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10562
-
core-ci voted on patch set 6 V -1 04/08/21, 22:51 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2123
-
Benni Mack uploaded patch set 7 04/08/21, 22:51
-
TYPO3com voted on patch set 7 V -1 04/08/21, 22:58 Completed build in 06m 38s on Thu, 8 Apr, 10:58 PM Test Summary: 99 of 33503 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10564
-
core-ci voted on patch set 7 V -1 04/08/21, 23:05 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2125
-
Oliver Hader commented on patch set 7 04/09/21, 11:46
ModuleTemplate.php:230Maybe `request` is not required as class-member here, but `ModuleTemplateFactory` could resolve the module configuration... -
Benni Mack commented on patch set 7 04/09/21, 12:21
ModuleTemplate.php:230ReplyThe benefit of having the request inside the ModuleTemplate allows us to refactor various places inside ModuleTemplate with PSR-7 instead of relying on _GP and getIndpEnv() -
Benni Mack commented on patch set 7 04/09/21, 12:22
LinkBrowserController.php:45ReplyThat's in the AbstractLinkBrowserController -
Oli Bartsch uploaded patch set 8 04/09/21, 12:47
-
core-ci voted on patch set 8 V -1 04/09/21, 12:48 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2137
-
Oli Bartsch uploaded patch set 9 04/09/21, 13:03
-
TYPO3com voted on patch set 9 V -1 04/09/21, 13:04 Completed build in 24s on Fri, 9 Apr, 01:04 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10573
-
core-ci voted on patch set 9 V -1 04/09/21, 13:05 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2139
-
Oli Bartsch uploaded patch set 10 04/09/21, 14:49
-
TYPO3com voted on patch set 10 V -1 04/09/21, 14:56 Completed build in 06m 43s on Fri, 9 Apr, 02:56 PM Test Summary: 101 of 33503 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10578
-
core-ci voted on patch set 10 V -1 04/09/21, 15:07 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2144
-
Oli Bartsch uploaded patch set 11 04/09/21, 15:19
-
TYPO3com voted on patch set 11 V -1 04/09/21, 15:27 Completed build in 07m 42s on Fri, 9 Apr, 03:27 PM Test Summary: 99 of 33503 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10579
-
core-ci voted on patch set 11 V -1 04/09/21, 15:35 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2145
-
Benni Mack uploaded patch set 12 04/09/21, 15:39
-
TYPO3com voted on patch set 12 V +1 04/09/21, 15:46 Completed build in 06m 03s on Fri, 9 Apr, 03:46 PM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10580
-
core-ci voted on patch set 12 V +1 04/09/21, 15:52 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2146
-
Benni Mack voted on patch set 12 V +1 CR +1 04/09/21, 16:02
-
Oli Bartsch uploaded patch set 13 04/09/21, 16:19
-
Oli Bartsch voted on patch set 13 V +1 CR +1 04/09/21, 16:19
-
TYPO3com voted on patch set 13 V +1 04/09/21, 16:25 Completed build in 06m 09s on Fri, 9 Apr, 04:25 PM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10581
-
core-ci voted on patch set 13 V +1 04/09/21, 16:33 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2148
-
Benni Mack uploaded patch set 14 04/09/21, 17:50
-
TYPO3com commented on patch set 14 04/09/21, 17:55 Completed build in 04m 51s on Fri, 9 Apr, 05:55 PM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10582
-
core-ci commented on patch set 14 04/09/21, 18:03 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2149
-
Oliver Hader commented on patch set 14 04/09/21, 19:58
LinkBrowserController.php:45ReplyAlright, I missed #93885ModuleTemplate.php:230ReplyAlright, fine. -
Oliver Hader voted on patch set 14 V +1 CR +1 04/09/21, 20:09
-
Oliver Hader voted on patch set 14 V +2 CR +2 04/09/21, 20:09
-
Benni Mack merged patch set 15 04/09/21, 20:27
LinkBrowserController.php:45