Review main Merged

68729[TASK] Set ModuleTemplate details from request

Benni Mack CR +2 V +2 Expert +1334 −1006 updated 04/09/21, 20:27

Commit message

This change adds a new ModuleTemplateFactory, which
is built with the Request in the object, allowing to use
the current request of the current action.

At the same time, all TYPO3 Core controllers
use proper DependencyInjection now, making it easier
to spot the dependencies and uses PSR-7 Request
where possible.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Oli Bartsch +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 70

Show 50 more files

Review log 2350

Show 1125 earlier messages
  1. Benni Mack uploaded patch set 1 04/08/21, 12:18

  2. TYPO3com voted on patch set 1 V +1 04/08/21, 12:25 Completed build in 07m 25s on Thu, 8 Apr, 12:25 PM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10555

  3. core-ci voted on patch set 1 V +1 04/08/21, 12:30 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2116

  4. Benni Mack uploaded patch set 2 04/08/21, 19:19

  5. TYPO3com voted on patch set 2 V -1 04/08/21, 19:26 Completed build in 06m 45s on Thu, 8 Apr, 07:26 PM Test Summary: 549 of 33503 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10557

  6. core-ci voted on patch set 2 V -1 04/08/21, 19:33 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2118

  7. Benni Mack uploaded patch set 3 04/08/21, 20:39

  8. TYPO3com voted on patch set 3 V -1 04/08/21, 20:45 Completed build in 06m 20s on Thu, 8 Apr, 08:45 PM Test Summary: 848 of 33503 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10559

  9. core-ci voted on patch set 3 V -1 04/08/21, 20:53 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2120

  10. Benni Mack uploaded patch set 4 04/08/21, 21:05

  11. TYPO3com voted on patch set 4 V -1 04/08/21, 21:13 Completed build in 07m 53s on Thu, 8 Apr, 09:13 PM Test Summary: 105 of 33503 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10560

  12. Benni Mack uploaded patch set 5 04/08/21, 21:19

  13. core-ci voted on patch set 4 V -1 04/08/21, 21:19 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2121

  14. TYPO3com voted on patch set 5 V -1 04/08/21, 21:27 Completed build in 08m 20s on Thu, 8 Apr, 09:27 PM Test Summary: 99 of 33503 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10561

  15. core-ci voted on patch set 5 V -1 04/08/21, 21:33 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2122

  16. Benni Mack rebased onto patch set 6 04/08/21, 22:37

  17. TYPO3com voted on patch set 6 V -1 04/08/21, 22:43 Completed build in 05m 53s on Thu, 8 Apr, 10:43 PM Test Summary: 99 of 33503 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10562

  18. core-ci voted on patch set 6 V -1 04/08/21, 22:51 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2123

  19. Benni Mack uploaded patch set 7 04/08/21, 22:51

  20. TYPO3com voted on patch set 7 V -1 04/08/21, 22:58 Completed build in 06m 38s on Thu, 8 Apr, 10:58 PM Test Summary: 99 of 33503 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10564

  21. core-ci voted on patch set 7 V -1 04/08/21, 23:05 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2125

  22. Oliver Hader commented on patch set 7 04/09/21, 11:46

    LinkBrowserController.php:45

    `$this->linkService` seems to be missing, doesn't it?

    ModuleTemplate.php:230

    Maybe `request` is not required as class-member here, but `ModuleTemplateFactory` could resolve the module configuration...
  23. Benni Mack commented on patch set 7 04/09/21, 12:21

    ModuleTemplate.php:230 Reply

    The benefit of having the request inside the ModuleTemplate allows us to refactor various places inside ModuleTemplate with PSR-7 instead of relying on _GP and getIndpEnv()
  24. Benni Mack commented on patch set 7 04/09/21, 12:22

    LinkBrowserController.php:45 Reply

    That's in the AbstractLinkBrowserController
  25. Oli Bartsch uploaded patch set 8 04/09/21, 12:47

  1. core-ci voted on patch set 8 V -1 04/09/21, 12:48 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2137

  2. Oli Bartsch uploaded patch set 9 04/09/21, 13:03

  3. TYPO3com voted on patch set 9 V -1 04/09/21, 13:04 Completed build in 24s on Fri, 9 Apr, 01:04 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10573

  4. core-ci voted on patch set 9 V -1 04/09/21, 13:05 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2139

  5. Oli Bartsch uploaded patch set 10 04/09/21, 14:49

  6. TYPO3com voted on patch set 10 V -1 04/09/21, 14:56 Completed build in 06m 43s on Fri, 9 Apr, 02:56 PM Test Summary: 101 of 33503 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10578

  7. core-ci voted on patch set 10 V -1 04/09/21, 15:07 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2144

  8. Oli Bartsch uploaded patch set 11 04/09/21, 15:19

  9. TYPO3com voted on patch set 11 V -1 04/09/21, 15:27 Completed build in 07m 42s on Fri, 9 Apr, 03:27 PM Test Summary: 99 of 33503 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10579

  10. core-ci voted on patch set 11 V -1 04/09/21, 15:35 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2145

  11. Benni Mack uploaded patch set 12 04/09/21, 15:39

  12. TYPO3com voted on patch set 12 V +1 04/09/21, 15:46 Completed build in 06m 03s on Fri, 9 Apr, 03:46 PM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10580

  13. core-ci voted on patch set 12 V +1 04/09/21, 15:52 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2146

  14. Benni Mack voted on patch set 12 V +1 CR +1 04/09/21, 16:02

  15. Oli Bartsch uploaded patch set 13 04/09/21, 16:19

  16. Oli Bartsch voted on patch set 13 V +1 CR +1 04/09/21, 16:19

  17. TYPO3com voted on patch set 13 V +1 04/09/21, 16:25 Completed build in 06m 09s on Fri, 9 Apr, 04:25 PM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10581

  18. core-ci voted on patch set 13 V +1 04/09/21, 16:33 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2148

  19. Benni Mack uploaded patch set 14 04/09/21, 17:50

  20. TYPO3com commented on patch set 14 04/09/21, 17:55 Completed build in 04m 51s on Fri, 9 Apr, 05:55 PM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10582

  21. core-ci commented on patch set 14 04/09/21, 18:03 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2149

  22. Oliver Hader commented on patch set 14 04/09/21, 19:58

    LinkBrowserController.php:45 Reply

    Alright, I missed #93885

    ModuleTemplate.php:230 Reply

    Alright, fine.
  23. Oliver Hader voted on patch set 14 V +1 CR +1 04/09/21, 20:09

  24. Oliver Hader voted on patch set 14 V +2 CR +2 04/09/21, 20:09

  25. Benni Mack merged patch set 15 04/09/21, 20:27