Review main Merged

6873[BUGFIX] Warnings in BE when using "Find filename"

Dmitry Dulepov CR +2 V +2 Normal +32 −28 updated 06/03/13, 20:49

Commit message

When using "Tools">"DB Check">"Find filename" with a slash
character (for example, "</title>"), there are warnings about
wrong regular expression in the Backend and nothing is found.

Review

  • Code review CR +2
    • Tolleiv Nietsch +2
    • Markus Klein +1
    • Susi Moog +1
  • Verified V +2
    • Tolleiv Nietsch +2
    • Markus Klein +1
    • Susi Moog +1

Issues 1

Files 1

Review log 14

  1. Markus Klein commented on patch set 2 01/22/12, 11:52

    Looks good to me, but someone else must approve No-brainer
  2. Markus Klein uploaded patch set 3 01/22/12, 11:52

  3. Markus Klein commented on patch set 3 01/22/12, 11:52

    Verified; Looks good to me, but someone else must approve Still a no-brainer. Added some CGL cleanup.
  4. Tolleiv Nietsch commented on patch set 4 V 0 01/22/12, 11:52

    by team member; Looks good to me, approved @Susanne - reading the bug description I assume that come from our security guys and is more meant to make the interface more robust - and for me it turned out that it also improved speed for the mentioned test search :)
  5. Markus Klein uploaded patch set 4 01/22/12, 11:52

  6. Markus Klein commented on patch set 4 01/22/12, 11:52

    Verified; Looks good to me, but someone else must approve
  7. Susi Moog commented on patch set 4 01/22/12, 11:52

    Verified; Looks good to me, but someone else must approve Change is in general fine by me and maybe I'm being stupid but how do you get a slash in a filename? (yes, it should be escaped, no question, but for me it does not make much sense to search for a _filename_ with a slash in it)
  8. Oliver Hader commented on patch set 2 01/22/12, 11:52

    Rebasing to master V:0, R:0
  9. Oliver Hader uploaded patch set 2 01/22/12, 11:52

  10. Mr. Jenkins commented on patch set 1 01/22/12, 11:52

  11. Mr. Jenkins commented on patch set 2 01/22/12, 11:52

  12. Mr. Jenkins commented on patch set 3 01/22/12, 11:52

  13. Mr. Jenkins commented on patch set 4 01/22/12, 11:52

  14. Tolleiv Nietsch merged patch set 4 01/22/12, 11:52