6873[BUGFIX] Warnings in BE when using "Find filename"
Commit message
Review
-
Code review CR +2
- Tolleiv Nietsch +2
- Markus Klein +1
- Susi Moog +1
-
Verified V +2
- Tolleiv Nietsch +2
- Markus Klein +1
- Susi Moog +1
Issues 1
Files 1
Review log 14
-
Markus Klein commented on patch set 2 01/22/12, 11:52
Looks good to me, but someone else must approve No-brainer -
Markus Klein uploaded patch set 3 01/22/12, 11:52
-
Markus Klein commented on patch set 3 01/22/12, 11:52
Verified; Looks good to me, but someone else must approve Still a no-brainer. Added some CGL cleanup. -
Tolleiv Nietsch commented on patch set 4 V 0 01/22/12, 11:52
by team member; Looks good to me, approved @Susanne - reading the bug description I assume that come from our security guys and is more meant to make the interface more robust - and for me it turned out that it also improved speed for the mentioned test search :) -
Markus Klein uploaded patch set 4 01/22/12, 11:52
-
Markus Klein commented on patch set 4 01/22/12, 11:52
Verified; Looks good to me, but someone else must approve -
Susi Moog commented on patch set 4 01/22/12, 11:52
Verified; Looks good to me, but someone else must approve Change is in general fine by me and maybe I'm being stupid but how do you get a slash in a filename? (yes, it should be escaped, no question, but for me it does not make much sense to search for a _filename_ with a slash in it) -
Oliver Hader commented on patch set 2 01/22/12, 11:52
Rebasing to master V:0, R:0 -
Oliver Hader uploaded patch set 2 01/22/12, 11:52
-
Mr. Jenkins commented on patch set 1 01/22/12, 11:52
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2477/ : SUCCESS -
Mr. Jenkins commented on patch set 2 01/22/12, 11:52
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2659/ : SUCCESS -
Mr. Jenkins commented on patch set 3 01/22/12, 11:52
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/3001/ : SUCCESS -
Mr. Jenkins commented on patch set 4 01/22/12, 11:52
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/3002/ : SUCCESS -
Tolleiv Nietsch merged patch set 4 01/22/12, 11:52