Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.

Review main Work in progress Orphaned

68730[WIP][TASK] Add <typo3-backend-button> component

Benjamin Franzke CR 0 V -1 Normal +132 −2 updated 11/29/21, 10:06

Commit message

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 7
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/30/68730/7 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/30/68730/7 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V -1 Blocked
    • core-ci -1 CI

Relation chain 2

  1. main 68200[WIP][TASK] Implement ConfigurationModule as custom element Based on this change Work in progress Merge conflict Benjamin Franzke CR 0 V -1 lit Hard +441 −193

    The chain has patch set 11 of 17, the changes above it need a rebase.

  2. 68730 [WIP][TASK] Add <typo3-backend-button> component This change

Files 6

Review log 1022

  1. Benjamin Franzke uploaded patch set 1 04/08/21, 15:17

  2. TYPO3com voted on patch set 1 V -1 04/08/21, 15:17 Completed build in 17s on Thu, 8 Apr, 03:17 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10556

  3. core-ci voted on patch set 1 V +1 04/08/21, 15:27 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2117

  4. Benjamin Franzke rebased onto patch set 2 04/12/21, 16:06

  5. TYPO3com voted on patch set 2 V -1 04/12/21, 16:07 Completed build in 18s on Mon, 12 Apr, 04:06 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10621

  6. core-ci voted on patch set 2 V +1 04/12/21, 16:27 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2198

  7. Benjamin Franzke commented on patch set 2 04/14/21, 08:33

    ButtonElement.ts:32 Unresolved

    Consider consistent tooltips vs labels vs titles handling (pointed out by Jonas Eberle).
  8. Benjamin Franzke uploaded patch set 3 04/17/21, 07:40

    Rebase
  9. TYPO3com voted on patch set 3 V -1 04/17/21, 07:40 Completed build in 18s on Sat, 17 Apr, 07:40 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10705

  10. core-ci voted on patch set 3 V +1 04/17/21, 08:01 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2304

  11. Benjamin Franzke rebased onto patch set 4 04/19/21, 05:10

  12. TYPO3com voted on patch set 4 V -1 04/19/21, 05:10 Completed build in 16s on Mon, 19 Apr, 05:10 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10712

  13. core-ci voted on patch set 4 V +1 04/19/21, 05:32 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2317

  14. Benjamin Franzke uploaded patch set 5 04/24/21, 04:14

  15. TYPO3com voted on patch set 5 V -1 04/24/21, 04:14 Completed build in 15s on Sat, 24 Apr, 04:14 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10851

  16. core-ci voted on patch set 5 V -1 04/24/21, 04:33 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10673

  17. Benjamin Franzke uploaded patch set 6 04/26/21, 22:01

  18. core-ci voted on patch set 6 V +1 04/26/21, 22:24 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10717

  19. Benjamin Franzke wrote 04/27/21, 14:54

    Topic set to lit
  20. Martin Kutschker uploaded patch set 7 05/09/21, 20:32

  21. core-ci voted on patch set 7 V -1 05/09/21, 20:43 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11325

  22. Benni Mack wrote 11/29/21, 10:06

    Change destination moved from master to main