Review 10.4 Merged

68740[BUGFIX] Apply enableFields in JOIN's ON condition

Georg Ringer CR +2 V +2 Normal +178 −32 updated 04/15/21, 17:08

Commit message

If an OUTER JOIN is requested, the "disabled" rows
of the joined table must be filtered before the join
is executed. Therefore the enableFields conditions
must be applied in the ON condition of the join.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
  • Verified V +2 Done
    • Georg Ringer +2
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 5

Review log 35

  1. Georg Ringer commented on patch set 1 04/15/21, 12:30

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 04/15/21, 12:38 Completed build in 07m 38s on Thu, 15 Apr, 12:38 PM Test Summary: 75954 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1311

  3. core-ci voted on patch set 1 V +1 04/15/21, 12:44 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2259

  4. Georg Ringer voted on patch set 1 V +2 CR +2 04/15/21, 17:08

  5. Georg Ringer merged patch set 2 04/15/21, 17:08